Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏷️ Refactor Datamodule names #354

Merged
merged 4 commits into from
Jun 9, 2022
Merged

🏷️ Refactor Datamodule names #354

merged 4 commits into from
Jun 9, 2022

Conversation

samet-akcay
Copy link
Contributor

Description

  • This PR refactors the name of the datamodules. This will be one of the basis of the Anomalib CLI. For example MVTecDataModule has been renamed to MVTec. This because Anomalib CLI will be able to choose the data from the CLI such as python train.py --data MVTec.

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@samet-akcay samet-akcay marked this pull request as ready for review June 8, 2022 14:42
djdameln
djdameln approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@samet-akcay samet-akcay merged commit 8afd247 into development Jun 9, 2022
@samet-akcay samet-akcay deleted the refactor/sa/modify-datamodules branch June 9, 2022 10:30
samet-akcay added a commit that referenced this pull request Jun 9, 2022
@samet-akcay
🏷️ Refactor Datamodule names (#354)
b2d6f62 
* Refactored MVTec datamodule

* 🏷️  Rename BTech datamodule

* 🏷️  Rename Folder datamodule

* 🛠 Fix the config files for draem and fastflow
samet-akcay added a commit that referenced this pull request Jun 17, 2022
@ashwinvaidya17 @samet-akcay
📝 Add benchmarking notebook (#353)
9f1c4a1 
* Add benchmarking

* 🏷️ Refactor Datamodule names  (#354)

* Refactored MVTec datamodule

* 🏷️  Rename BTech datamodule

* 🏷️  Rename Folder datamodule

* 🛠 Fix the config files for draem and fastflow

* Add descriptions

* Refactor folder structure

* Add notebooks linting to pre_merge

Co-authored-by: Ashwin Vaidya <ashwinitinvaidya@gmail.com>
Co-authored-by: Samet Akcay <samet.akcay@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwinvaidya17 ashwinvaidya17 ashwinvaidya17 approved these changes

@djdameln djdameln djdameln approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samet-akcay @ashwinvaidya17 @djdameln