📝 Add benchmarking notebook #353
Conversation
|
Before we merge this PR needs to be merged #343 as the changes that fix the tests are on this branch |
There was a problem hiding this comment.
When you name it as 101, did you follow the naming convention here?
https://github.com/openvinotoolkit/openvino_notebooks/blob/main/CONTRIBUTING.md#notebook-naming
Just curious
I drew inspiration from |
|
Great, that's what I wanted to hear:) |
* Refactored MVTec datamodule * 🏷️ Rename BTech datamodule * 🏷️ Rename Folder datamodule * 🛠 Fix the config files for draem and fastflow
| @@ -0,0 +1,391 @@ | |||
| { | |||
There was a problem hiding this comment.
Maybe you could give a little bit explanation here how you've created this configuration file. Just a few sentences explaining that the parameters were copied from the default padim config in anomalib/models/padim/config.yaml, and which sections were changed. Otherwise the reader might think that they need to set all these parameters manually.
Reply via ReviewNB
| @@ -0,0 +1,391 @@ | |||
| { | |||
There was a problem hiding this comment.
Same here. Maybe add a few sentences explaining that benchmarking is configured through a yaml file, and briefly mention what kind of settings can be configured through this config file.
Reply via ReviewNB
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Description
Add benchmarking example + colab badge. Only benchmarking notebook is tested on google colab
Fixes Error while running benchmark.py on GPU #185
Partially addresses Add documentation about google colab #254