move threshold params to metric configuration callback #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwinvaidya17
approved these changes
May 23, 2022
samet-akcay
approved these changes
May 23, 2022
samet-akcay
added a commit
that referenced
this pull request
May 24, 2022
…e class arguments. (#315) * Created metrics callback to access the metric params in the module * Added metrics callback to get_callback function * 🗑 Removed hparams from visualizer callback * 🗑 Removed hparams from visualizer callback * ☑️ Check if image and pixel metrics exist in anomaly module in normalization callbacks * ➕ Add tiling callback to setup the tiler without configuring the model. * ➕ Add log_images_to flag to VisualizerCallback * 🗑 Removed hparams from AnomalyModule and PadimLightning * 🛠 Fix dummy module to be initialized with explicit arguments * ➕ Refactor dfm model * Make thresholding parameters optional in AnomalyModule * 🗑 Remove pixel threshold from DFM * create default image and pixel threshold attributes in AnomalyModule * 🗑 Remove hparams from DFM model and ➕explicit arguments. * 🗑 Remove hparams from Patchcore model and ➕explicit arguments. * 🗑 Remove hparams from Stfpm model and ➕explicit arguments. * 🗑 Remove hparams from GANomaly model and ➕explicit arguments. * 🗑 Remove hparams from Cflow model and ➕explicit arguments. * Removed normalization and Fix the tests * 📦 wrapped PadimLightning model from Padim * 📦 wrapped PatchcoreLightning model from Patchcore * 📦 wrapped StfpmLightning model from Stfpm * 📦 wrapped CflowLightning model from Cflow * 📦 wrapped CflowLightning model from Cflow * 📦 wrapped DfkdeLightning model from Dfkde * 📦 wrapped Dfm and Ganomaly models * ⏪ Revert DummyModule and visualizer tests * Fix visualizer tests * Fix normalization tests * Add metrics to lightning module * 🗑 Remove metrics callback * 🛠️ Fix metrics callback and tests * 🛠️ Fix metrics callback and tests * 🛠 Revert on_fit_start to setup in MetricCallback to properly assign threholds in test * ➕ Added docstring to clarify to-be-deprecated methods * 🏷 Renamed MetricCallback to MetricConfigurationCallback * 🏷 Renamed TilerCallback to TilerConfigurationCallback * 🏷 Renamed MetricCallback to MetricsConfigurationCallback * 🏷 Renamed tiler.py to tiler_configuration.py * ⏪ Removed instance check in cdf normalization * 🚚 Move threshold params to metric configuration callback (#328) Co-authored-by: Dick Ameln <dick.ameln@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the thresholding parameters outside of the model parameters section. This also removes the thresholding-related arguments from the base class, which leads to a cleaner implementation of that class. The responsibility of configuring the threshold metric classes is moved from the base task to the metrics callback.
Changes
Checklist