Refactor AnomalyModule and LightningModules to explicitly define class arguments.

[samet-akcay]

Description

• This PR refactors AnomalyModule and LightningModules to explicitly define class arguments. Current design depends on hparams variable, which is a DictConfig. Despite being convenient, it is not explicit such that the user may not now what exactly needed to construct a model class. The proposed implementation addresses this explicitly construct the model classes.

Changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist

• My code follows the pre-commit style and check guidelines of this project.
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing tests pass locally with my changes

[ashwinvaidya17]

Thanks for the efforts! I have a few minor comments.

[djdameln]

Thanks. One concern that I'm having with these configuration callbacks, is that it might confuse the user. MetricsCallback may sound like it is responsible for collecting the outputs and computing the performance metrics, while in practive it is only used to initialize the metric collections. When more callbacks like this get added, it might be good to make a clear distinction between these configuration callbacks and the other callbacks. Maybe we could keep them in a separate folder and/or add a postfix to the class names, e.g. MetricsConfigurationCallback.

[ashwinvaidya17]

Thanks! I am fine with the changes.

[samet-akcay]

@djdameln, if you are happy with the final changes we could merge this PR today

[djdameln]

Great work, thanks!