Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 Increase tolerance + nightly path fix #318

Merged
merged 1 commit into from
May 17, 2022
Merged

🐞 Increase tolerance + nightly path fix #318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/nightly/models/test_model_nightly.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def _test_metrics(self, trainer, config, model, datamodule):
if "optimization" in config.keys() and "nncf" in config.optimization.keys() and config.optimization.nncf.apply:
threshold = threshold.nncf
if not (
np.isclose(results["image_AUROC"], threshold["image_AUROC"], rtol=0.02)
np.isclose(results["image_AUROC"], threshold["image_AUROC"], rtol=0.05)
or (results["image_AUROC"] >= threshold["image_AUROC"])
):
raise AssertionError(
Expand All @@ -100,7 +100,7 @@ def _test_metrics(self, trainer, config, model, datamodule):

if config.dataset.task == "segmentation":
if not (
np.isclose(results["pixel_AUROC"], threshold["pixel_AUROC"], rtol=0.02)
np.isclose(results["pixel_AUROC"], threshold["pixel_AUROC"], rtol=0.05)
or (results["pixel_AUROC"] >= threshold["pixel_AUROC"])
):
raise AssertionError(
Expand Down
2 changes: 1 addition & 1 deletion tests/nightly/tools/benchmarking/test_benchmarking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def check_csv(model: str):

def test_benchmarking():
"""Test if benchmarking script produces the required artifacts."""
config_path = "tests/pre_merge/tools/benchmarking/benchmark_params.yaml"
config_path = "tests/nightly/tools/benchmarking/benchmark_params.yaml"
test_config = OmegaConf.load(config_path)
test_config.grid_search.dataset["path"] = [get_dataset_path()]

Expand Down