Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悶 Increase tolerance + nightly path fix #318

Merged
merged 1 commit into from
May 17, 2022
Merged

馃悶 Increase tolerance + nightly path fix #318

merged 1 commit into from
May 17, 2022

Conversation

ashwinvaidya17
Copy link
Collaborator

Description

  • Increase tolerance for nightly tests
  • Fix path for benchmarking tests

djdameln
djdameln approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of allowing a tolerance, we could also just lower the threshold. This would be a bit more readable (just an idea, don't need to change it now).

@samet-akcay samet-akcay merged commit dd89f1e into development May 17, 2022
@samet-akcay samet-akcay deleted the fix/av/nightly branch May 17, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samet-akcay samet-akcay samet-akcay approved these changes

@djdameln djdameln djdameln approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashwinvaidya17 @samet-akcay @djdameln