Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃洜 Fix get_version in setup.py to avoid hard-coding version. #229

Merged
merged 1 commit into from
Apr 13, 2022
Merged

馃洜 Fix get_version in setup.py to avoid hard-coding version. #229

merged 1 commit into from
Apr 13, 2022

Conversation

samet-akcay
Copy link
Contributor

Description

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@samet-akcay samet-akcay added Enhancement New feature or request Version labels Apr 13, 2022
@samet-akcay samet-akcay requested review from ashwinvaidya17 and djdameln and removed request for ashwinvaidya17 April 13, 2022 10:20
ashwinvaidya17
ashwinvaidya17 approved these changes Apr 13, 2022
View reviewed changes
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried creating a whl from this. Versioning works!

@samet-akcay samet-akcay merged commit eb7bbde into development Apr 13, 2022
@samet-akcay samet-akcay deleted the version/sa/remove-hard-coded-version branch April 13, 2022 12:15
@samet-akcay samet-akcay mentioned this pull request Apr 21, 2022
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwinvaidya17 ashwinvaidya17 ashwinvaidya17 approved these changes

@djdameln djdameln Awaiting requested review from djdameln

Assignees
No one assigned
Labels
Enhancement New feature or request Version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

version is hard-coded in setup.py. This should be read from either VERSION.txt file or in anomalib.__init__.py
2 participants
@samet-akcay @ashwinvaidya17