Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/read version #153

Closed

Conversation

dreaquil
Copy link
Contributor

Description

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@samet-akcay samet-akcay self-requested a review March 22, 2022 11:27
@samet-akcay
Copy link
Contributor

@dreaquil, thank you for creating the PR. There is currently a problem with our CI. Once fixed, we'll test this.

@dreaquil
Copy link
Contributor Author

Resolved 0.2.5 merge conflict.

@samet-akcay samet-akcay added Setup Enhancement New feature or request labels Apr 1, 2022
@samet-akcay samet-akcay added this to the v.0.2.6 milestone Apr 4, 2022
@samet-akcay
Copy link
Contributor

samet-akcay commented Apr 6, 2022

@dreaquil CI fails when VERSION is used, which was the reason why the version was hardcoded as a temporary fix. I'll look into it. I've attached the log file here.

CI.log

@samet-akcay samet-akcay self-assigned this Apr 13, 2022
@samet-akcay
Copy link
Contributor

PR #229 addressed the issue. We had to modify get_version function. We could close this PR. Thanks for the efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Setup
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

version is hard-coded in setup.py. This should be read from either VERSION.txt file or in anomalib.__init__.py
2 participants