Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast the string to EfficientAdModelSize enum #2182

Conversation

samet-akcay
Copy link
Contributor

๐Ÿ“ Description

โœจ Changes

Select what type of change your PR is:

  • ๐Ÿž Bug fix (non-breaking change which fixes an issue)
  • ๐Ÿ”จ Refactor (non-breaking change which refactors the code base)
  • ๐Ÿš€ New feature (non-breaking change which adds functionality)
  • ๐Ÿ’ฅ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ๐Ÿ“š Documentation update
  • ๐Ÿ”’ Security update

โœ… Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • ๐Ÿ“‹ I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • ๐Ÿ“š I have made the necessary updates to the documentation (if applicable).
  • ๐Ÿงช I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

@samet-akcay
Copy link
Contributor Author

Didn't realise that there is already another PR for this, so closing
#2159

@samet-akcay samet-akcay deleted the refactor/add-efficient-ad-model-size-check branch July 10, 2024 10:29
@samet-akcay samet-akcay added this to the v1.1.1 milestone Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Issue with self.model_size Initialization in EfficientAD Class
1 participant