Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: efficient ad model_size str fixes #2159

Merged
merged 4 commits into from
Jul 10, 2024
Merged

Conversation

Gornoka
Copy link
Contributor

@Gornoka Gornoka commented Jun 27, 2024

πŸ“ Description

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • πŸ”¨ Refactor (non-breaking change which refactors the code base)
  • πŸš€ New feature (non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • πŸ“š Documentation update
  • πŸ”’ Security update

βœ… Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • πŸ“‹ I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • πŸ“š I have made the necessary updates to the documentation (if applicable).
  • πŸ§ͺ I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

Signed-off-by: Lukas Hennies <lukas.hennies@anticipate.ml>
Signed-off-by: Lukas Hennies <lukas.hennies@anticipate.ml>
also pre-commit
Signed-off-by: Lukas Hennies <lukas.hennies@anticipate.ml>
@Gornoka Gornoka changed the title fix: efficient ad str things fix: efficient ad model_size str fixes Jun 27, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.78%. Comparing base (56843d2) to head (1ae5637).
Report is 5 commits behind head on main.

Files Patch % Lines
...malib/models/image/efficient_ad/lightning_model.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2159      +/-   ##
==========================================
- Coverage   80.80%   80.78%   -0.03%     
==========================================
  Files         248      248              
  Lines       10859    10859              
==========================================
- Hits         8775     8772       -3     
- Misses       2084     2087       +3     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@samet-akcay samet-akcay enabled auto-merge (squash) July 10, 2024 12:40
@samet-akcay samet-akcay merged commit 9582b1d into openvinotoolkit:main Jul 10, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Issue with self.model_size Initialization in EfficientAD Class
2 participants