Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualizer show classification and segmentation #178

Merged
merged 11 commits into from
Apr 8, 2022
Merged

Visualizer show classification and segmentation #178

merged 11 commits into from
Apr 8, 2022

Conversation

alexriedel1
Copy link
Contributor

This would be a possible fix to #175 (comment)

Alternatively, the classification image could always be added as it provides useful insights in what the model predicted.

@samet-akcay samet-akcay added Callbacks Enhancement New feature or request Requires Changes Reviewers request changes, which should be addressed by the PR maker and removed Requires Changes Reviewers request changes, which should be addressed by the PR maker labels Apr 1, 2022
@samet-akcay samet-akcay self-requested a review April 1, 2022 12:09
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr, would you be able to resolve the merge conflicts so we could run the CI?

@alexriedel1
Copy link
Contributor Author

Thanks for the pr, would you be able to resolve the merge conflicts so we could run the CI?

Ah right! Just want to note that after merging this PR #181 the proposed solution needs to be updated..

@samet-akcay
Copy link
Contributor

@alexriedel1, the CI has been fixed now. Could you please update the PR by pulling the latest development? Thanks!

@alexriedel1
Copy link
Contributor Author

@alexriedel1, the CI has been fixed now. Could you please update the PR by pulling the latest development? Thanks!

done

@alexriedel1
Copy link
Contributor Author

I merged the development branch and fixed some styling errors

@samet-akcay
Copy link
Contributor

@alexriedel1, we've run the CI. There are two tests that failed unexpectedly. We'll have a look why this is the case, and let you know. I don't expect you to look the tests:)

Here is the CI log showing why it failed:
CI-PR-178.log

@alexriedel1
Copy link
Contributor Author

alexriedel1 commented Apr 6, 2022

@alexriedel1, we've run the CI. There are two tests that failed unexpectedly. We'll have a look why this is the case, and let you know. I don't expect you to look the tests:)

Here is the CI log showing why it failed: CI-PR-178.log

It's because the class VisualizerCallback now has to be initialized with a task. I can check that and fix it if you want.
/Edit: You can check my solution to this now. Another way would be to set a default task value in the VisualizerCallback but I guess this is a bit counter intuitive.

Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the efforts!

Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for another nice contribution. I just have some minor comments

anomalib/utils/callbacks/visualizer_callback.py Outdated Show resolved Hide resolved
anomalib/utils/callbacks/visualizer_callback.py Outdated Show resolved Hide resolved
@samet-akcay samet-akcay merged commit 548852f into openvinotoolkit:development Apr 8, 2022
@alexriedel1 alexriedel1 deleted the vis_cls_seg branch April 8, 2022 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants