Fix KeyError:'label' in classification folder dataset
#175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Line 48 in 8c1a04f |
djdameln
approved these changes
Mar 30, 2022
| visualizer.add_image(image=vis_img, title="Segmentation Result") | ||
| self._add_images(visualizer, pl_module, Path(filename)) | ||
| visualizer.close() | ||
| if isinstance(outputs, dict) and "mask" in outputs.keys(): |
There was a problem hiding this comment.
It would be good if we could also visualize the results when no masks are not available, but we could address this separately.
There was a problem hiding this comment.
Exactly, similar to what @alexriedel1 proposed. A separate PR would address this
|
Hi @alexriedel1, yes, that would definitely make sense. I've created this PR as a hotfix to address this bug. Not sure if I have time to address the classification visualization issue today, but it's been on our list for a while. Perhaps, we could address that in a separate PR? |
samet-akcay
deleted the
fix/sa/label-issue-in-classification-folder-dataset
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This hotfix proposes a fix to return
labelinfolderdataset whenclassificationtask is chosen. Currently thefolderdataset doesn't returnlabelinclassification, which ultimately causes a failed validation.PR also bumps up the black version due to a version dependency, resulting in some changes in some modules.
Fixes Issues with heatmap scaling when training without masks #173
Changes
Checklist