Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug: 865] datamodule.setup() assertion failed #1058

Merged
merged 4 commits into from
Apr 28, 2023
Merged

[Bug: 865] datamodule.setup() assertion failed #1058

merged 4 commits into from
Apr 28, 2023

Conversation

isaacncz
Copy link
Contributor

@isaacncz isaacncz commented Apr 28, 2023 •
edited
Loading

[Bug: 865] datamodule.setup() assertion failed

This fix download the dataset first before splitting the train/val/test sets.

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have added a summary of my changes to the CHANGELOG (not for minor changes, docs and tests).

Ng, Che Zhek added 2 commits April 27, 2023 21:23
[Bug: 839] Crop in SSPCAB implementation
a08af4e 
This fix follows the official implementation for the SSPCAB by the original author

Fixes openvinotoolkit#839

Signed-off-by: Ng, Kin Nam <kin.nam.ng@intel.com>
Signed-off-by: Lim, Kuan Xian <kuan.xian.lim@intel.com>
[Bug: 865] datamodule.setup() assertion failed
3624155 
This fix download the dataset first before splitting the train/val/test sets.

Fixes openvinotoolkit#865

Signed-off-by: Ng, Kin Nam <kin.nam.ng@intel.com>
Signed-off-by: Lim, Kuan Xian <kuan.xian.lim@intel.com>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@isaacncz isaacncz changed the title Bug 865 dev [Bug: 865] datamodule.setup() assertion failed Apr 28, 2023
[Bug: 839] Crop in SSPCAB implementation
79a2eab 
This fix follows the official implementation for the SSPCAB by the original author

Fixes openvinotoolkit#839

Signed-off-by: Ng, Kin Nam <kin.nam.ng@intel.com>
Signed-off-by: Lim, Kuan Xian <kuan.xian.lim@intel.com>

remove trailing whitespace
@ashwinvaidya17 ashwinvaidya17 self-requested a review April 28, 2023 08:07
samet-akcay
samet-akcay approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

ashwinvaidya17
ashwinvaidya17 approved these changes Apr 28, 2023
View reviewed changes
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@samet-akcay samet-akcay added the T4 label Apr 28, 2023
@samet-akcay samet-akcay merged commit 97b885f into openvinotoolkit:main Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwinvaidya17 ashwinvaidya17 ashwinvaidya17 approved these changes

@samet-akcay samet-akcay samet-akcay approved these changes

@djdameln djdameln Awaiting requested review from djdameln

Assignees
No one assigned
Labels
Notebooks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Ignore dotfiles in datasets - datamodule.setup() assertion failed
3 participants
@isaacncz @ashwinvaidya17 @samet-akcay