Skip to content

Commit

Permalink
[Bug: 865] datamodule.setup() assertion failed (#1058)
Browse files Browse the repository at this point in the history
* [Bug: 839] Crop in SSPCAB implementation
This fix follows the official implementation for the SSPCAB by the original author

Fixes #839

Signed-off-by: Ng, Kin Nam <kin.nam.ng@intel.com>
Signed-off-by: Lim, Kuan Xian <kuan.xian.lim@intel.com>

* [Bug: 865] datamodule.setup() assertion failed

This fix download the dataset first before splitting the train/val/test sets.

Fixes #865

Signed-off-by: Ng, Kin Nam <kin.nam.ng@intel.com>
Signed-off-by: Lim, Kuan Xian <kuan.xian.lim@intel.com>

* [Bug: 839] Crop in SSPCAB implementation
This fix follows the official implementation for the SSPCAB by the original author

Fixes #839

Signed-off-by: Ng, Kin Nam <kin.nam.ng@intel.com>
Signed-off-by: Lim, Kuan Xian <kuan.xian.lim@intel.com>

remove trailing whitespace

---------

Signed-off-by: Ng, Kin Nam <kin.nam.ng@intel.com>
Signed-off-by: Lim, Kuan Xian <kuan.xian.lim@intel.com>
Co-authored-by: Samet Akcay <samet.akcay@intel.com>
  • Loading branch information
isaacncz and samet-akcay committed Apr 28, 2023
1 parent eadb75a commit 97b885f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions notebooks/000_getting_started/001_getting_started.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -229,8 +229,8 @@
],
"source": [
"datamodule = get_datamodule(config)\n",
"datamodule.setup() # Downloads the dataset if it's not in the specified `root` directory\n",
"datamodule.prepare_data() # Create train/val/test/prediction sets.\n",
"datamodule.prepare_data() # Downloads the dataset if it's not in the specified `root` directory\n",
"datamodule.setup() # Create train/val/test/prediction sets.\n",
"\n",
"i, data = next(enumerate(datamodule.val_dataloader()))\n",
"print(data.keys())"
Expand Down

0 comments on commit 97b885f

Please sign in to comment.