Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move event deposits into delegated storage setters #163

Closed
wants to merge 10 commits into from
Closed

Move event deposits into delegated storage setters #163

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b3e0c6f
Move event deposits into delegated storage setters
Jul 11, 2023
d568066
Add EmissionSet event with arguments for netuid, emission
Jul 20, 2023
cafb884
Events/add events emitted tests (#175)
camfairchild Aug 10, 2023
26122ae
remove assert_ok outside of macro
camfairchild Aug 14, 2023
c331e13
add diff_adjustment event test
camfairchild Aug 14, 2023
89a60ef
add event emitted test for brun adjust
camfairchild Aug 14, 2023
3c5f448
add tests for sudo setters
camfairchild Aug 14, 2023
b63ae35
add test for sudo set val epoch len
camfairchild Aug 14, 2023
a351325
make sure to deposit events for val hyp param set
camfairchild Aug 14, 2023
ff83611
Merge main to deposit events everywhere (#176)
camfairchild Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions pallets/subtensor/src/networks.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,9 +126,9 @@ impl<T: Config> Pallet<T> {
ensure!( netuid_a != netuid_b, Error::<T>::InvalidConnectionRequirement );
ensure!( Self::if_subnet_exist( netuid_a ), Error::<T>::NetworkDoesNotExist );
ensure!( Self::if_subnet_exist( netuid_b ), Error::<T>::NetworkDoesNotExist );

Self::add_connection_requirement( netuid_a, netuid_b, requirement );
log::info!("NetworkConnectionAdded( netuid_a:{:?}, netuid_b:{:?} requirement: {:?} )", netuid_a, netuid_b, requirement);
Self::deposit_event( Event::NetworkConnectionAdded( netuid_a, netuid_b, requirement ) );

Ok(())
}

Expand All @@ -151,9 +151,9 @@ impl<T: Config> Pallet<T> {
ensure_root( origin )?;
ensure!( Self::if_subnet_exist( netuid_a ), Error::<T>::NetworkDoesNotExist );
ensure!( Self::if_subnet_exist( netuid_b ), Error::<T>::NetworkDoesNotExist );
Self::remove_connection_requirment( netuid_a, netuid_b );
log::info!("NetworkConnectionRemoved( netuid_a:{:?}, netuid_b:{:?} )", netuid_a, netuid_b );
Self::deposit_event( Event::NetworkConnectionRemoved( netuid_a, netuid_b ) );

Self::remove_connection_requirement( netuid_a, netuid_b );

Ok(())
}

Expand Down Expand Up @@ -346,12 +346,20 @@ impl<T: Config> Pallet<T> {
//
pub fn add_connection_requirement( netuid_a: u16, netuid_b: u16, requirement: u16 ) {
NetworkConnect::<T>::insert( netuid_a, netuid_b, requirement );

log::info!("NetworkConnectionAdded( netuid_a:{:?}, netuid_b:{:?} requirement: {:?} )", netuid_a, netuid_b, requirement);
Self::deposit_event( Event::NetworkConnectionAdded( netuid_a, netuid_b, requirement ) );
}

// --- Removes the network b connection requirement from network a.
//
pub fn remove_connection_requirment( netuid_a: u16, netuid_b: u16) {
if Self::network_connection_requirement_exists(netuid_a, netuid_b) { NetworkConnect::<T>::remove( netuid_a, netuid_b ); }
pub fn remove_connection_requirement( netuid_a: u16, netuid_b: u16 ) {
if Self::network_connection_requirement_exists( netuid_a, netuid_b ) {
NetworkConnect::<T>::remove( netuid_a, netuid_b );

log::info!("NetworkConnectionRemoved( netuid_a:{:?}, netuid_b:{:?} )", netuid_a, netuid_b );
Self::deposit_event( Event::NetworkConnectionRemoved( netuid_a, netuid_b ) );
}
}

// Returns true if the items contain duplicates.
Expand Down
Loading
Loading