Move event deposits into delegated storage setters #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camfairchild
requested changes
Jul 11, 2023
This is true, and is the standard for pallets from Paritytech. They have some code in the collective pallet for checking emitted event history which is super helpful. |
|
Love that this is being worked on so promptly after I mentioned it in Discord. This will make indexing the chain much nicer! |
* add macro to check events emitted * use macro for emission set test
camfairchild
approved these changes
Aug 14, 2023
* Add motion duration argument to Collective::propose with minimum duration * Update CouncilMotionDuration 6 DAYS -> 12 HOURS * Up spec_version -> 127 * Fix testing and benchmarks for propose change and auto threshold * 🤖 🧈 Reformat source code * Remove husky hooks for pre-push, pre-commit, post-commit (#162) * Prevent unstake call from allowing zero amount (#165) * Remove senate instance of collective pallet (#166) * Add scheduler pallet to runtime (#164) * Add scheduler pallet to runtime * Update runtime/src/lib.rs Co-authored-by: Cameron Fairchild <cameron@opentensor.ai> --------- Co-authored-by: Cameron Fairchild <cameron@opentensor.ai> * Remove unused validator-related hyperparameters (#167) * Fix PrivilegeCmp invalid origin enum in runtime * Cargo fix run, eliminating all compiler warnings (#169) * Up DefaultWeightsSetRateLimit -> 100 (#168) * Up DefaultWeightsSetRateLimit -> 100 * Fix weight rate limit tests * Run cargo fmt on workspace (#170) * Emergency fix for block_step when dealing with empty networks * Decrease max weight limit (#149) * update version key for netuid 1 * decrease max weight limit * Update hyperparameters.md --------- Co-authored-by: Cameron Fairchild <cameron@opentensor.ai> * keep emission set event * run cargo fmt --------- Co-authored-by: Ayden Brewer <dalegribble@riseup.net> Co-authored-by: Ala Shaabana <shaabana@gmail.com> Co-authored-by: Eugene-hu <85906264+Eugene-hu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change moves all storage-setter related event deposits into the delegated function, allowing events to be emitted when the runtime changes storage values outside of sudo calls.
Checklist