fix: get rid of duplicate channel logic #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmihalcik-virtru
approved these changes
May 29, 2024
ttschampel
pushed a commit
that referenced
this pull request
Jun 13, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>0.1.0</summary> ## 0.1.0 (2024-06-13) ### Features * add code to create services for SDK ([#35](#35)) ([28513e6](28513e6)) * add logging ([#49](#49)) ([9d20647](9d20647)) * Add NanoTDF E2E Tests ([#75](#75)) ([84f9bd1](84f9bd1)) * **codegen:** Generate and publish Java Proto generated artifacts ([#2](#2)) ([2328fd2](2328fd2)) * crypto API ([#33](#33)) ([b8295b7](b8295b7)) * NanoTDF Implementation ([#46](#46)) ([6485326](6485326)) * **PLAT-3087:** zip reader-writer ([#23](#23)) ([3eeb626](3eeb626)) * SDK Encrypt (with mocked rewrap) ([#45](#45)) ([d67daa2](d67daa2)) * **sdk:** add CLI and integration tests ([#64](#64)) ([df20e6d](df20e6d)) * **sdk:** add ssl context ([#58](#58)) ([80246a9](80246a9)) * **sdk:** get e2e rewrap working ([#52](#52)) ([fe2c04b](fe2c04b)) * **sdk:** Issue [#60](#60) - expose SDK ([#61](#61)) ([ddef62a](ddef62a)) * **sdk:** provide access tokens dynamically to KAS ([#51](#51)) ([04ca715](04ca715)) * **sdk:** update archive support ([#47](#47)) ([29a80a9](29a80a9)) ### Bug Fixes * create TDFs larger than a single segment ([#65](#65)) ([e1da325](e1da325)) * fix pom for release please ([#77](#77)) ([3a3c357](3a3c357)) * Force BC provider use ([#76](#76)) ([1bc9dd9](1bc9dd9)) * get rid of duplicate channel logic ([#59](#59)) ([1edd666](1edd666)) * **sdk:** allow SDK to handle protocols in addresses ([#70](#70)) ([97ae8ee](97ae8ee)) * **sdk:** make sdk auto closeable ([#63](#63)) ([c1bbbb4](c1bbbb4)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
This was referenced Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was easy to overlook the difference between how KAS channels and channels used to communicate with the platform
were made. This puts the creation code in the same place.