Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk): add ssl context #58

Merged
merged 2 commits into from
May 29, 2024
Merged

feat(sdk): add ssl context #58

merged 2 commits into from
May 29, 2024

Conversation

ttschampel
Copy link
Member

@ttschampel ttschampel commented May 28, 2024 •
edited
Loading

@ttschampel ttschampel requested review from a team as code owners May 28, 2024 19:52
@ttschampel ttschampel changed the title Feature/add ssl context feature(sdk): add ssl context May 28, 2024
@ttschampel ttschampel changed the title feature(sdk): add ssl context feat(sdk): add ssl context May 28, 2024
mkleene
mkleene reviewed May 28, 2024
View reviewed changes
Copy link
Contributor

@mkleene mkleene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to use something like this: https://stackoverflow.com/a/47638460/285915 to do this. I'd rather not pull in netty on the client side if we don't need to. OTOH it's probably not a big deal if there is a real reason.

.github/workflows/checks.yaml Outdated Show resolved Hide resolved
pom.xml Show resolved Hide resolved
sdk/src/main/java/io/opentdf/platform/sdk/SDKBuilder.java Show resolved Hide resolved
@ttschampel
Copy link
Member Author

Is it possible to use something like this: https://stackoverflow.com/a/47638460/285915 to do this. I'd rather not pull in netty on the client side if we don't need to. OTOH it's probably not a big deal if there is a real reason.

Updated to use approach you linked

@ttschampel ttschampel requested a review from mkleene May 29, 2024 01:58
@ttschampel
Issue #57 - add SSLContext for comms. also update to java 17
f7b6e44 
Issue #57 - add docs

rollback to jdk 11 :(,  Address PR comments = use protocol lib independant approach.  Add SSL test
mkleene
mkleene approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@mkleene mkleene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tests are great. I think that we can get rid of the dependencies I flagged but if that's not possible then fine.

pom.xml Show resolved Hide resolved
sdk/pom.xml Show resolved Hide resolved
@ttschampel ttschampel mentioned this pull request May 29, 2024
Open
@ttschampel ttschampel merged commit 80246a9 into main May 29, 2024
3 checks passed
@ttschampel ttschampel deleted the feature/add_ssl_context branch May 29, 2024 15:36
@opentdf-automation opentdf-automation bot mentioned this pull request May 29, 2024
Merged
ttschampel pushed a commit that referenced this pull request Jun 13, 2024
@opentdf-automation
chore(main): release 0.1.0 (#22)
56f0463 
🤖 I have created a release *beep* *boop*
---


<details><summary>0.1.0</summary>

## 0.1.0 (2024-06-13)


### Features

* add code to create services for SDK
([#35](#35))
([28513e6](28513e6))
* add logging ([#49](#49))
([9d20647](9d20647))
* Add NanoTDF E2E Tests
([#75](#75))
([84f9bd1](84f9bd1))
* **codegen:** Generate and publish Java Proto generated artifacts
([#2](#2))
([2328fd2](2328fd2))
* crypto API ([#33](#33))
([b8295b7](b8295b7))
* NanoTDF Implementation
([#46](#46))
([6485326](6485326))
* **PLAT-3087:** zip reader-writer
([#23](#23))
([3eeb626](3eeb626))
* SDK Encrypt (with mocked rewrap)
([#45](#45))
([d67daa2](d67daa2))
* **sdk:** add CLI and integration tests
([#64](#64))
([df20e6d](df20e6d))
* **sdk:** add ssl context
([#58](#58))
([80246a9](80246a9))
* **sdk:** get e2e rewrap working
([#52](#52))
([fe2c04b](fe2c04b))
* **sdk:** Issue [#60](#60) -
expose SDK ([#61](#61))
([ddef62a](ddef62a))
* **sdk:** provide access tokens dynamically to KAS
([#51](#51))
([04ca715](04ca715))
* **sdk:** update archive support
([#47](#47))
([29a80a9](29a80a9))


### Bug Fixes

* create TDFs larger than a single segment
([#65](#65))
([e1da325](e1da325))
* fix pom for release please
([#77](#77))
([3a3c357](3a3c357))
* Force BC provider use
([#76](#76))
([1bc9dd9](1bc9dd9))
* get rid of duplicate channel logic
([#59](#59))
([1edd666](1edd666))
* **sdk:** allow SDK to handle protocols in addresses
([#70](#70))
([97ae8ee](97ae8ee))
* **sdk:** make sdk auto closeable
([#63](#63))
([c1bbbb4](c1bbbb4))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
This was referenced Aug 27, 2024
Closed
Closed
@opentdf-automation opentdf-automation bot mentioned this pull request Sep 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkleene mkleene mkleene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ttschampel @mkleene