NO-JIRA: rhel-9.4/c9s: make versioning scheme semver compatible #1615
Conversation
openshift-ci
bot
added
the
approved
given the preceding sentence I'm not sure I understand this statement fully |
There's a bunch of things out there that currently parse the RHCOS version string. The semantics of this string will change as part of this change, but we should at least try to retain the same semver-compatible format. E.g. currently, an RHCOS version string of the `ocp-rhel-9.4` variant is 418.94.202409090849-0. Before this PR, An RHCOS version string of the `rhel-9.4` variant is 9.4.202409090849.0, which is not semver compatible. With this PR, the latter would now be 9.4.202409090849-0 (note the change from `.0` to `-0`).
jlebon
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@jlebon: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jlebon: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
I had to do a little digging to find automatic-version-suffix.
/lgtm
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
Updated the git message to make this clearer! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: c4rt0, jbtrystram, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
There's a bunch of things out there that currently parse the RHCOS
version string. The semantics of this string will change as part of this
change, but we should at least try to retain the same semver-compatible
format.
E.g. currently, an RHCOS version string of the
ocp-rhel-9.4variantis 418.94.202409090849-0. Before this PR, An RHCOS version string
of the
rhel-9.4variant is 9.4.202409090849.0, which is not semvercompatible. With this PR, the latter would now be 9.4.202409090849-0
(note the change from
.0to-0).