Skip to content

Commit

Permalink
rhel-9.4/c9s: make versioning scheme semver compatible
Browse files Browse the repository at this point in the history
There's a bunch of things out there that currently parse the RHCOS
version string. The semantics of this string will change as part of this
change, but we should at least try to retain the same semver-compatible
format.

E.g. currently, an RHCOS version string of the `ocp-rhel-9.4` variant
is 418.94.202409090849-0. Before this PR, An RHCOS version string
of the `rhel-9.4` variant is 9.4.202409090849.0, which is not semver
compatible. With this PR, the latter would now be 9.4.202409090849-0
(note the change from `.0` to `-0`).
  • Loading branch information
jlebon committed Sep 10, 2024
1 parent 1bf9fa6 commit 698cb39
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions manifest-c9s.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ repos:
# In that case, the versioning should instead be exactly the same as the pungi
# compose ID.
automatic-version-prefix: "9.<date:%Y%m%d%H%M>"
# This ensures we're semver-compatible which OpenShift wants
automatic-version-suffix: "-"

mutate-os-release: "9"

Expand Down
2 changes: 2 additions & 0 deletions manifest-rhel-9.4.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ repos:
# In that case, the versioning should instead be exactly the same as the pungi
# compose ID.
automatic-version-prefix: "9.4.<date:%Y%m%d%H%M>"
# This ensures we're semver-compatible which OpenShift wants
automatic-version-suffix: "-"

mutate-os-release: "9.4"

Expand Down

0 comments on commit 698cb39

Please sign in to comment.