-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-12837: Add Shielded VMs configuration to gcp provider types #1371
Conversation
Hello @eranco74! Some important instructions when contributing to openshift/api: For merging purposes, this repository follows the no-Feature-Freeze process which means that in addition to the standard
OR
Who should apply these qe/docs/px labels?
|
I'd like to see this feature contributed to the upstream cluster API provider for GCP before we merge this downstream |
|
API changes look ok, as this feature will be supported by the Machine API team, I'd like to see their QE and docs team ack this before we merge. CC @jeana-redhat @sunzhaohua2 will you both have capacity to document and test this feature respectively within 4.12? CC @makentenza can you please link the ocpcloud epic for this once you've created it so we can get the acks recorded there |
QE can test this in 4.12 |
Apologies, just to be clear, I meant 4.13, not 4.12, my bad |
Should be no problem for 4.13, thanks! |
@eranco74: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
What's the status of getting this feature implemented in the upstream GCP cluster API provider? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eranco74, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ahh upstream is good |
cc @miyadav, @jeana-redhat, @sferich888 |
/label qe-approved |
/label px-approved |
LGTM for 4.13 /label docs-approved |
Add support to Shielded VMs on GCP
Feature link: https://issues.redhat.com/browse/OCPBU-158