MGMT-12837: Add Shielded VMs configuration to gcp provider types

[eranco74]

Add support to Shielded VMs on GCP
Feature link: https://issues.redhat.com/browse/OCPBU-158

[openshift-ci]

Hello @eranco74! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

For merging purposes, this repository follows the no-Feature-Freeze process which means that in addition to the standard lgtm and approved labels this repository requires either:

bugzilla/valid-bug - applied if your PR references a valid bugzilla bug

OR

qe-approved, docs-approved, and px-approved - these labels can be applied by anyone in the openshift org via the /label <labelname> command.

Who should apply these qe/docs/px labels?

• For a no-Feature-Freeze team who is merging a feature before code freeze, they need to get those labels applied to their api repo PR by the appropriate teams (i.e. qe, docs, px)
• For a Feature Freeze (traditional) team who is merging a feature before FF, they can self-apply the labels (via /label commands), they are basically irrelevant for those teams
• For a Feature Freeze team who is merging a feature after FF, the PR should be rejected barring an exception

[JoelSpeed]

I'd like to see this feature contributed to the upstream cluster API provider for GCP before we merge this downstream
/hold

[eranco74]

I'd like to see this feature contributed to the upstream cluster API provider for GCP before we merge this downstream /hold

kubernetes-sigs/cluster-api-provider-gcp#777

[JoelSpeed]

API changes look ok, as this feature will be supported by the Machine API team, I'd like to see their QE and docs team ack this before we merge.

CC @jeana-redhat @sunzhaohua2 will you both have capacity to document and test this feature respectively within 4.12?

CC @makentenza can you please link the ocpcloud epic for this once you've created it so we can get the acks recorded there

[sunzhaohua2]

CC @jeana-redhat @sunzhaohua2 will you both have capacity to document and test this feature respectively within 4.12?

QE can test this in 4.12

[JoelSpeed]

Apologies, just to be clear, I meant 4.13, not 4.12, my bad

[jeana-redhat]

Should be no problem for 4.13, thanks!

[openshift-ci]

@eranco74: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[JoelSpeed]

/lgtm

[JoelSpeed]

What's the status of getting this feature implemented in the upstream GCP cluster API provider?

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[JoelSpeed]

Ahh upstream is good
/hold cancel

[eranco74]

cc @miyadav, @jeana-redhat, @sferich888
Please add the qe-approved, docs-approved px-approved labels
This is part of https://issues.redhat.com/browse/OCPCLOUD-1828

[miyadav]

/label qe-approved

[sferich888]

/label px-approved

[jeana-redhat]

LGTM for 4.13

/label docs-approved