-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-12839: Add Shielded VMs options to gcp mpool and TF #6698
Conversation
Looks like you need to check our terraform linting as well as golint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, this looks good. The commit message should be fleshed out according to our contributing guidelines. Generally I would expect this to be several commits, probably along the lines of: adding type to machine pools, add support in machinesets, and terraform; but this is small enough to be manageable as is.
01caf9a
to
8be023f
Compare
Example usage, update the install-config compute or controlPlane platform field:
|
3e9cf2c
to
f9cf4f9
Compare
note that the shileded_instance_config options have 3 states: 1. User-specified enabled 2. User-specified disabled 3. Not user-specfiied: default The shileded_instance_config is defined as dynamic block and will be only in case the user specified it. This should allow us to get the cloud provider default in case the user didn't specify the config (and will not require code updates if the cloud provider default changes).
@eranco74: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add support to Shielded VMs on GCP
Feature link: https://issues.redhat.com/browse/OCPBU-158