Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docs and link checker workflow #139

Merged
merged 10 commits into from
Jun 25, 2021
Merged

Add Docs and link checker workflow #139

merged 10 commits into from
Jun 25, 2021

Conversation

davidcui1225
Copy link
Contributor

@davidcui1225 davidcui1225 commented Jun 23, 2021

Description

  • Add releasing.md for branching
  • Update documentation links
  • Add link checker workflow
  • Rename workbench artifacts to kebab case

Note: After PR is merged, will merge develop into main and delete develop branch and rest of tasks needed for #135

Issues Resolved

#137

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

davidcui1225 and others added 7 commits June 23, 2021 16:19
Signed-off-by: David Cui <davidcui@amazon.com>
Bumps [glob-parent](https://github.com/gulpjs/glob-parent) from 5.1.1 to 5.1.2.
- [Release notes](https://github.com/gulpjs/glob-parent/releases)
- [Changelog](https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md)
- [Commits](gulpjs/glob-parent@v5.1.1...v5.1.2)

---
updated-dependencies:
- dependency-name: glob-parent
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2021

Codecov Report

❗ No coverage uploaded for pull request base (develop@2025fa9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #139   +/-   ##
==========================================
  Coverage           ?   99.89%           
  Complexity         ?     2471           
==========================================
  Files              ?      245           
  Lines              ?     5748           
  Branches           ?      333           
==========================================
  Hits               ?     5742           
  Misses             ?        5           
  Partials           ?        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2025fa9...d6f9de5. Read the comment docs.

…in dev guide

Signed-off-by: David Cui <davidcui@amazon.com>
Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidcui1225 davidcui1225 merged commit d513f79 into develop Jun 25, 2021
@davidcui1225 davidcui1225 deleted the add-docs branch June 25, 2021 21:36
davidcui1225 added a commit that referenced this pull request Jun 26, 2021
* Support construct AggregationResponseParser during Aggregator build stage (#108)

* Support construct AggregationResponseParser during Aggregator build stage

* modify the doc

Signed-off-by: penghuo <penghuo@gmail.com>

* Impl stddev and variance function in SQL and PPL (#115)

* impl variance frontend and backend

* Support construct AggregationResponseParser during Aggregator build stage

* add var and varp for PPL

Signed-off-by: penghuo <penghuo@gmail.com>

* add UT

Signed-off-by: penghuo <penghuo@gmail.com>

* fix UT

Signed-off-by: penghuo <penghuo@gmail.com>

* fix doc format

Signed-off-by: penghuo <penghuo@gmail.com>

* fix doc format

Signed-off-by: penghuo <penghuo@gmail.com>

* fix the doc

Signed-off-by: penghuo <penghuo@gmail.com>

* add stddev_samp and stddev_pop

Signed-off-by: penghuo <penghuo@gmail.com>

* fix UT coverage

* address comments

Signed-off-by: penghuo <penghuo@gmail.com>

* Fix the aggregation filter missing in named aggregators (#123)

* Take the condition expression as property to the named aggregator when wrapping the delegated aggregator

Signed-off-by: chloe-zh <chloezh1102@gmail.com>

* update

Signed-off-by: chloe-zh <chloezh1102@gmail.com>

* Added test case where filtered agg is not pushed down

Signed-off-by: chloe-zh <chloezh1102@gmail.com>

* update

Signed-off-by: chloe-zh <chloezh1102@gmail.com>

* update

Signed-off-by: chloe-zh <chloezh1102@gmail.com>

* Rename gradle tasks in the manner of Opensearch (#133)

Signed-off-by: Zhongnan Su <szhongna@amazon.com>

* add testing-library/user-event to pass CI (#141)

Signed-off-by: David Cui <davidcui@amazon.com>

* Deprecated legacy settings instead of removing (#140)

* Deprecated cursor enabling and fetch size setting

Signed-off-by: penghuo <penghuo@gmail.com>

* update doc

Signed-off-by: penghuo <penghuo@gmail.com>

* add more deprecated settings

Signed-off-by: penghuo <penghuo@gmail.com>

* Add Codecov to SQL  (#138)

* add codecov to CI workflow

Signed-off-by: David Cui <davidcui@amazon.com>

* add codecov token
Signed-off-by: David Cui <davidcui@amazon.com>

* Add Docs and link checker workflow (#139)

* save progress on doc renaming

* update rest of documentation links
Signed-off-by: David Cui <davidcui@amazon.com>

* add workbench developer guide and update readme
Signed-off-by: David Cui <davidcui@amazon.com>

* Bump glob-parent from 5.1.1 to 5.1.2 in /workbench

Bumps [glob-parent](https://github.com/gulpjs/glob-parent) from 5.1.1 to 5.1.2.
- [Release notes](https://github.com/gulpjs/glob-parent/releases)
- [Changelog](https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md)
- [Commits](gulpjs/glob-parent@v5.1.1...v5.1.2)

---
updated-dependencies:
- dependency-name: glob-parent
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* add testing-library
Signed-off-by: David Cui <davidcui@amazon.com>

* rename workbench artifact name to kebab case
Signed-off-by: David Cui <davidcui@amazon.com>

* standardize maintainers list based on team roles, fix workbench name in dev guide
Signed-off-by: David Cui <davidcui@amazon.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* add links to exclude from link checker
Signed-off-by: David Cui <davidcui@amazon.com>

* fix localhost exclusion flag
Signed-off-by: David Cui <davidcui@amazon.com>

* add all exclusion links, revert localhost exclusion away from regex
Signed-off-by: David Cui <davidcui@amazon.com>

* fix family.zzz exclusion, remove stale link from odbc sign_installers
Signed-off-by: David Cui <davidcui@amazon.com>

* fix lychee workflow after local testing and replace old sign_installers url
Signed-off-by: David Cui <davidcui@amazon.com>

* remove accidental duplicate exclude flag
Signed-off-by: David Cui <davidcui@amazon.com>

* remove sign installers as it is out of date
Signed-off-by: David Cui <davidcui@amazon.com>

Co-authored-by: Peng Huo <penghuo@gmail.com>
Co-authored-by: Chloe <chloezh1102@gmail.com>
Co-authored-by: Zhongnan Su <szhongna@amazon.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants