Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename doctest gradle tasks in the manner of Opensearch #133

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

zhongnansu
Copy link
Member

@zhongnansu zhongnansu commented Jun 21, 2021

Signed-off-by: Zhongnan Su szhongna@amazon.com

Description

  1. Rename gradle tasks in the manner of Opensearch
  2. Fix testDistribution flag to pass local test.

Issues Resolved

#118

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Zhongnan Su <szhongna@amazon.com>
@zhongnansu zhongnansu changed the title Rename gradle tasks in the manner of Opensearch Rename doctest gradle tasks in the manner of Opensearch Jun 21, 2021
@zhongnansu zhongnansu self-assigned this Jun 21, 2021
Copy link
Contributor

@chloe-zh chloe-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@zhongnansu zhongnansu merged commit 70af5bd into opensearch-project:develop Jun 21, 2021
davidcui1225 added a commit that referenced this pull request Jun 26, 2021
* Support construct AggregationResponseParser during Aggregator build stage (#108)

* Support construct AggregationResponseParser during Aggregator build stage

* modify the doc

Signed-off-by: penghuo <penghuo@gmail.com>

* Impl stddev and variance function in SQL and PPL (#115)

* impl variance frontend and backend

* Support construct AggregationResponseParser during Aggregator build stage

* add var and varp for PPL

Signed-off-by: penghuo <penghuo@gmail.com>

* add UT

Signed-off-by: penghuo <penghuo@gmail.com>

* fix UT

Signed-off-by: penghuo <penghuo@gmail.com>

* fix doc format

Signed-off-by: penghuo <penghuo@gmail.com>

* fix doc format

Signed-off-by: penghuo <penghuo@gmail.com>

* fix the doc

Signed-off-by: penghuo <penghuo@gmail.com>

* add stddev_samp and stddev_pop

Signed-off-by: penghuo <penghuo@gmail.com>

* fix UT coverage

* address comments

Signed-off-by: penghuo <penghuo@gmail.com>

* Fix the aggregation filter missing in named aggregators (#123)

* Take the condition expression as property to the named aggregator when wrapping the delegated aggregator

Signed-off-by: chloe-zh <chloezh1102@gmail.com>

* update

Signed-off-by: chloe-zh <chloezh1102@gmail.com>

* Added test case where filtered agg is not pushed down

Signed-off-by: chloe-zh <chloezh1102@gmail.com>

* update

Signed-off-by: chloe-zh <chloezh1102@gmail.com>

* update

Signed-off-by: chloe-zh <chloezh1102@gmail.com>

* Rename gradle tasks in the manner of Opensearch (#133)

Signed-off-by: Zhongnan Su <szhongna@amazon.com>

* add testing-library/user-event to pass CI (#141)

Signed-off-by: David Cui <davidcui@amazon.com>

* Deprecated legacy settings instead of removing (#140)

* Deprecated cursor enabling and fetch size setting

Signed-off-by: penghuo <penghuo@gmail.com>

* update doc

Signed-off-by: penghuo <penghuo@gmail.com>

* add more deprecated settings

Signed-off-by: penghuo <penghuo@gmail.com>

* Add Codecov to SQL  (#138)

* add codecov to CI workflow

Signed-off-by: David Cui <davidcui@amazon.com>

* add codecov token
Signed-off-by: David Cui <davidcui@amazon.com>

* Add Docs and link checker workflow (#139)

* save progress on doc renaming

* update rest of documentation links
Signed-off-by: David Cui <davidcui@amazon.com>

* add workbench developer guide and update readme
Signed-off-by: David Cui <davidcui@amazon.com>

* Bump glob-parent from 5.1.1 to 5.1.2 in /workbench

Bumps [glob-parent](https://github.com/gulpjs/glob-parent) from 5.1.1 to 5.1.2.
- [Release notes](https://github.com/gulpjs/glob-parent/releases)
- [Changelog](https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md)
- [Commits](gulpjs/glob-parent@v5.1.1...v5.1.2)

---
updated-dependencies:
- dependency-name: glob-parent
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* add testing-library
Signed-off-by: David Cui <davidcui@amazon.com>

* rename workbench artifact name to kebab case
Signed-off-by: David Cui <davidcui@amazon.com>

* standardize maintainers list based on team roles, fix workbench name in dev guide
Signed-off-by: David Cui <davidcui@amazon.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* add links to exclude from link checker
Signed-off-by: David Cui <davidcui@amazon.com>

* fix localhost exclusion flag
Signed-off-by: David Cui <davidcui@amazon.com>

* add all exclusion links, revert localhost exclusion away from regex
Signed-off-by: David Cui <davidcui@amazon.com>

* fix family.zzz exclusion, remove stale link from odbc sign_installers
Signed-off-by: David Cui <davidcui@amazon.com>

* fix lychee workflow after local testing and replace old sign_installers url
Signed-off-by: David Cui <davidcui@amazon.com>

* remove accidental duplicate exclude flag
Signed-off-by: David Cui <davidcui@amazon.com>

* remove sign installers as it is out of date
Signed-off-by: David Cui <davidcui@amazon.com>

Co-authored-by: Peng Huo <penghuo@gmail.com>
Co-authored-by: Chloe <chloezh1102@gmail.com>
Co-authored-by: Zhongnan Su <szhongna@amazon.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants