-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change 2.0-alpha1 to 2.0-rc1. #946
Conversation
This change is blocked on opensearch-project/security#1764 being added to the distribution build. |
@DarshitChanpura I'm going to be unavaliable for a bit, could you help patch this pull request with update to the build paths? I made this one change without being able to verifiy it, opensearch-project/security@7434ebc We will need something similar done in this PR |
Once there's a successful distribution rc1 build CI will turn green here, let's retry later today. |
Codecov Report
@@ Coverage Diff @@
## main #946 +/- ##
=======================================
Coverage 72.14% 72.14%
=======================================
Files 87 87
Lines 1906 1906
Branches 242 242
=======================================
Hits 1375 1375
Misses 477 477
Partials 54 54 Continue to review full report at Codecov.
|
Signed-off-by: dblock <dblock@amazon.com>
Has OSD been bumped to rc1? https://github.com/opensearch-project/security-dashboards-plugin/blob/main/opensearch_dashboards.json#L4 |
Signed-off-by: dblock <dblock@amazon.com>
Thanks! @dblock |
@dblock I see that the version in the main branch is still Should this be updated? Please let me know if I'm missing something here. |
Ok, I don't know @kavilla ? |
In Core they just need verion=2.0.0 because they have another version=2.0.0-rc1 passed during build. @kavilla let me know if dashboards is like that. Thanks. |
Ah...got it...thank you @peterzhuamazon ! |
@kavilla let me know if dashboards is like that. Thanks. |
Revert in #947 |
Following opensearch-project/opensearch-build#1863, change 2.0-alpha1 to 2.0-rc1.