Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace alpha1 with rc1. #1863

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Replace alpha1 with rc1. #1863

merged 1 commit into from
Apr 14, 2022

Conversation

dblock
Copy link
Member

@dblock dblock commented Mar 30, 2022

Signed-off-by: dblock dblock@amazon.com

Description

Replace alpha1 with rc1. We're doing away with alpha.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock requested a review from a team as a code owner March 30, 2022 21:06
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2022

Codecov Report

Merging #1863 (de9a7f1) into main (14bbb60) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1863   +/-   ##
=========================================
  Coverage     94.46%   94.46%           
  Complexity       22       22           
=========================================
  Files           179      179           
  Lines          3649     3649           
  Branches         29       29           
=========================================
  Hits           3447     3447           
  Misses          196      196           
  Partials          6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14bbb60...de9a7f1. Read the comment docs.

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big change means a lot of the repos needs to change their ci as well.
Will block this until we clear up the confusion and final decision.

Thanks.

@bbarani
Copy link
Member

bbarani commented Mar 31, 2022

This is a big change means a lot of the repos needs to change their ci as well. Will block this until we clear up the confusion and final decision.

Thanks.

We will merge this PR once we have the working build with alpha qualifier.

@kavilla kavilla mentioned this pull request Apr 8, 2022
1 task
@peterzhuamazon
Copy link
Member

This is only for the build repo manifest, as all other plugin repos all need to change their default to rc1.

Signed-off-by: dblock <dblock@amazon.com>
@dblock
Copy link
Member Author

dblock commented Apr 11, 2022

This is only for the build repo manifest, as all other plugin repos all need to change their default to rc1.

Once this is merged, the rc1 value will be passed through to plugin builds and used via -Dopensearch... options. It will produce a -SNAPSHOT build of OpenSearch-min which then can be used to update the plugin CI. I will take care of it.

@peterzhuamazon
Copy link
Member

This is only for the build repo manifest, as all other plugin repos all need to change their default to rc1.

Once this is merged, the rc1 value will be passed through to plugin builds and used via -Dopensearch... options. It will produce a -SNAPSHOT build of OpenSearch-min which then can be used to update the plugin CI. I will take care of it.

So just to confirm you will send PR to all the plugin repos to change alpha1 to rc1 after build success, right?
Thanks.

@dblock
Copy link
Member Author

dblock commented Apr 11, 2022

This is only for the build repo manifest, as all other plugin repos all need to change their default to rc1.

Once this is merged, the rc1 value will be passed through to plugin builds and used via -Dopensearch... options. It will produce a -SNAPSHOT build of OpenSearch-min which then can be used to update the plugin CI. I will take care of it.

So just to confirm you will send PR to all the plugin repos to change alpha1 to rc1 after build success, right? Thanks.

Yes, that's what I am saying.

@dblock
Copy link
Member Author

dblock commented Apr 11, 2022

I saw @kavilla also made this change for OSD in #1949. Do you want me to update this to just do OpenSearch?

@peterzhuamazon
Copy link
Member

I saw @kavilla also made this change for OSD in #1949. Do you want me to update this to just do OpenSearch?

We will fix the alpha1 build to be green before switch to rc1.

@dblock
Copy link
Member Author

dblock commented Apr 13, 2022

@peterzhuamazon We have to merge this and ensure at least 1 successful RC1 SNAPSHOT build before we go PR changes in all plugins, otherwise their CIs will start failing because there's no opensearch-min-SNAPSHOT.

@peterzhuamazon
Copy link
Member

@dblock I approve.

Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprise no conflict but shouldn't be a big deal.

Can we get this merged in otherwise OpenSearch Dashboards sanity tests will fail.

@dblock dblock deleted the 2.0-rc1 branch April 15, 2022 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants