[Backport 2.9] [Backport 2.x] Change the order of the sections #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://github.com/avatars/u/80134844?s=60&v=4){kind=small}
* [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Change the order of the sections in the "Create detection rule" page #586 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * bugfix for tags validation Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Change the order of the sections in the "Create detection rule" page #586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications #601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Change the order of the sections in the "Create detection rule" page #586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications #601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Replace code editor with expression editor #602 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Replace code editor with expression editor #602 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Improve text area ux and add expression UI #603 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Code review Change the order of the sections #622 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> (cherry picked from commit e3c103e) Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> (cherry picked from commit c2ff25f)
Codecov Report
@@ Coverage Diff @@
## 2.9 #644 +/- ##
=======================================
Coverage 31.31% 31.31%
=======================================
Files 138 138
Lines 4375 4375
Branches 727 727
=======================================
Hits 1370 1370
Misses 2867 2867
Partials 138 138 |
amsiglan
approved these changes
Jul 12, 2023
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
…-project#634) (opensearch-project#644) * [FEATURE] Improve "list" text area UX opensearch-project#589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Improve "list" text area UX opensearch-project#589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Improve "list" text area UX opensearch-project#589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Improve "list" text area UX opensearch-project#589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Change the order of the sections in the "Create detection rule" page opensearch-project#586 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * bugfix for tags validation Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Change the order of the sections in the "Create detection rule" page opensearch-project#586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications opensearch-project#601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission opensearch-project#613 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Change the order of the sections in the "Create detection rule" page opensearch-project#586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications opensearch-project#601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission opensearch-project#613 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Replace code editor with expression editor opensearch-project#602 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Replace code editor with expression editor opensearch-project#602 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Improve text area ux and add expression UI opensearch-project#603 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Code review Change the order of the sections opensearch-project#622 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> (cherry picked from commit e3c103e) Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> (cherry picked from commit c2ff25f) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport c2ff25f from #634