Change the order of the sections #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
…pensearch-project#586 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
…-analytics-dashboards-plugin into Change_the_order_of_the_sections # Conflicts: # public/app.scss # public/pages/Rules/components/RuleEditor/RuleEditorForm.scss # public/pages/Rules/components/RuleEditor/components/YamlRuleEditorComponent/RuleTagsComboBox.tsx
Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
…ule" page opensearch-project#586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications opensearch-project#601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission opensearch-project#613 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
…ule" page opensearch-project#586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications opensearch-project#601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission opensearch-project#613 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
…ct#602 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
…ct#602 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
…-analytics-dashboards-plugin into Improve_list_text_area_UX # Conflicts: # cypress/integration/2_rules.spec.js # public/app.scss # public/pages/Rules/components/RuleEditor/DetectionVisualEditor.tsx
Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
…acvetkovic/security-analytics-dashboards-plugin into Change_the_order_of_the_sections # Conflicts: # public/pages/Rules/components/RuleEditor/DetectionVisualEditor.tsx # public/pages/Rules/components/RuleEditor/RuleEditorForm.tsx
…cacvetkovic/security-analytics-dashboards-plugin into Change_the_order_of_the_sections # Conflicts: # public/pages/Rules/components/RuleEditor/components/YamlRuleEditorComponent/RuleTagsComboBox.tsx
Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
jovancacvetkovic
requested review from
amsiglan,
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90 and
eirsep
as code owners
Codecov Report
@@ Coverage Diff @@
## main #622 +/- ##
==========================================
+ Coverage 31.48% 32.84% +1.35%
==========================================
Files 138 139 +1
Lines 4335 4451 +116
Branches 721 744 +23
==========================================
+ Hits 1365 1462 +97
+ Misses 2832 2812 -20
- Partials 138 177 +39 |
Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
|
@amsiglan, @AWSHurneyt should be backported to 2.x |
AWSHurneyt
reviewed
Jun 13, 2023
There was a problem hiding this comment.
@jovancacvetkovic PR opensearch-project/opensearch-dashboards-functional-test#657 will need to be updated as well I imagine, correct? It may be worthwhile to try running these test updates locally in the FTR to get an idea of whether any changes are needed for them to execute successfully. That way we can minimize differences between the tests maintained in both repos.
We had many redesigns for the rules, so I expect FTR to fail, but I will also try and find some time to test these changes locally. Anyway, I'll have to wait for the changes to be applied before moving these to FTR. |
That makes sense, I mostly just wanted to be mindful of the FTR. We had to provide manual sign off for the frontend during the 2.8 release, which was time consuming; so we should strive to have the FTR updated for the 2.9 release. |
…-analytics-dashboards-plugin into Change_the_order_of_the_sections
…' into Change_the_order_of_the_sections
amsiglan
reviewed
Jun 15, 2023
amsiglan
reviewed
Jun 15, 2023
public/pages/Rules/components/RuleEditor/DetectionVisualEditor.tsx
Outdated
Show resolved
Hide resolved
amsiglan
reviewed
Jun 15, 2023
public/pages/Rules/components/RuleEditor/DetectionVisualEditor.tsx
Outdated
Show resolved
Hide resolved
amsiglan
reviewed
Jun 15, 2023
public/pages/Rules/components/RuleEditor/DetectionVisualEditor.tsx
Outdated
Show resolved
Hide resolved
amsiglan
reviewed
Jun 15, 2023
public/pages/Rules/components/RuleEditor/components/SelectionExpField.tsx
Outdated
Show resolved
Hide resolved
amsiglan
reviewed
Jun 15, 2023
AWSHurneyt
reviewed
Jun 16, 2023
| } | ||
| ); | ||
|
|
||
| Cypress.Commands.add( |
There was a problem hiding this comment.
Just a quick note:
When these test updates are eventually added to the functional test repo, it'll be important to confirm that these custom cypress command names overlap with those used by the other plugins in the FTR.
There was a problem hiding this comment.
Correct, thanks for the reminder.
Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
amsiglan
approved these changes
Jun 21, 2023
AWSHurneyt
approved these changes
Jun 21, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 21, 2023
* [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Change the order of the sections in the "Create detection rule" page #586 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * bugfix for tags validation Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Change the order of the sections in the "Create detection rule" page #586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications #601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Change the order of the sections in the "Create detection rule" page #586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications #601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Replace code editor with expression editor #602 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Replace code editor with expression editor #602 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Improve text area ux and add expression UI #603 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Code review Change the order of the sections #622 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> (cherry picked from commit e3c103e)
amsiglan
pushed a commit
that referenced
this pull request
Jul 12, 2023
* [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Change the order of the sections in the "Create detection rule" page #586 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * bugfix for tags validation Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Change the order of the sections in the "Create detection rule" page #586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications #601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Change the order of the sections in the "Create detection rule" page #586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications #601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Replace code editor with expression editor #602 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Replace code editor with expression editor #602 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Improve text area ux and add expression UI #603 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Code review Change the order of the sections #622 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> (cherry picked from commit e3c103e) Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
opensearch-trigger-bot bot
added a commit
that referenced
this pull request
Jul 12, 2023
* [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Change the order of the sections in the "Create detection rule" page #586 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * bugfix for tags validation Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Change the order of the sections in the "Create detection rule" page #586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications #601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Change the order of the sections in the "Create detection rule" page #586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications #601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Replace code editor with expression editor #602 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Replace code editor with expression editor #602 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Improve text area ux and add expression UI #603 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Code review Change the order of the sections #622 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> (cherry picked from commit e3c103e) Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> (cherry picked from commit c2ff25f)
amsiglan
pushed a commit
that referenced
this pull request
Jul 12, 2023
* [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Change the order of the sections in the "Create detection rule" page #586 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * bugfix for tags validation Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Change the order of the sections in the "Create detection rule" page #586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications #601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Change the order of the sections in the "Create detection rule" page #586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications #601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Replace code editor with expression editor #602 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Replace code editor with expression editor #602 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Improve text area ux and add expression UI #603 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Code review Change the order of the sections #622 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> (cherry picked from commit e3c103e) Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> (cherry picked from commit c2ff25f) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
…-project#634) (opensearch-project#644) * [FEATURE] Improve "list" text area UX opensearch-project#589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Improve "list" text area UX opensearch-project#589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Improve "list" text area UX opensearch-project#589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Improve "list" text area UX opensearch-project#589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Change the order of the sections in the "Create detection rule" page opensearch-project#586 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * bugfix for tags validation Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Change the order of the sections in the "Create detection rule" page opensearch-project#586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications opensearch-project#601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission opensearch-project#613 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Change the order of the sections in the "Create detection rule" page opensearch-project#586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications opensearch-project#601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission opensearch-project#613 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Replace code editor with expression editor opensearch-project#602 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Replace code editor with expression editor opensearch-project#602 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Improve text area ux and add expression UI opensearch-project#603 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Code review Change the order of the sections opensearch-project#622 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> (cherry picked from commit e3c103e) Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> (cherry picked from commit c2ff25f) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sort and reorder the Creation detection rule UX components
Issues Resolved
Resolves #586
Resolves #601
Resolves #613
Resolves #589
Resolves #602
Resolves #620
Screenshots
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.