Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [bug] update installation commands in DEVELOPER_GUIDE.md #912

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport e53ba8e from #908

Signed-off-by: qiwen li <qiwen_li@brown.edu>
(cherry picked from commit e53ba8e)
@Hailong-am
Copy link
Collaborator

@MadaniKK
Copy link
Contributor

MadaniKK commented Oct 8, 2023

@MadaniKK could you fix the DOC check https://github.com/opensearch-project/opensearch-dashboards-functional-test/pull/912/checks?check_run_id=17497953466

Hi. Yes, but I am confused about what name and email we can use for signing off... I did sign off the commit, but just with a different name and email. I used the same name and email for sign-off when contributing to other OpenSearch repos. I found out other OpenSearch repos only require all commits to be signed off but don't specify the name and the email has to be "@users.noreply.github.com". Do I need to change my local git config to that name and email?

@Hailong-am
Copy link
Collaborator

@MadaniKK could you fix the DOC check https://github.com/opensearch-project/opensearch-dashboards-functional-test/pull/912/checks?check_run_id=17497953466

Hi. Yes, but I am confused about what name and email we can use for signing off... I did sign off the commit, but just with a different name and email. I used the same name and email for sign-off when contributing to other OpenSearch repos. I found out other OpenSearch repos only require all commits to be signed off but don't specify the name and the email has to be "@users.noreply.github.com". Do I need to change my local git config to that name and email?

can you check your email settings of github with link https://github.com/settings/emails, that should be the same one with signing off

@MadaniKK
Copy link
Contributor

MadaniKK commented Oct 8, 2023

@MadaniKK could you fix the DOC check https://github.com/opensearch-project/opensearch-dashboards-functional-test/pull/912/checks?check_run_id=17497953466

Hi. Yes, but I am confused about what name and email we can use for signing off... I did sign off the commit, but just with a different name and email. I used the same name and email for sign-off when contributing to other OpenSearch repos. I found out other OpenSearch repos only require all commits to be signed off but don't specify the name and the email has to be "@users.noreply.github.com". Do I need to change my local git config to that name and email?

can you check your email settings of github with link https://github.com/settings/emails, that should be the same one with signing off

I just checked, It is actually the same email but in my GitHub email setting, I enabled "Keep my email addresses private". Now I disabled it, also I changed my GitHub profile name to match the local git config. I think now it should be able to pass the DCO check... Is there a way to trigger the DCO check again?

@Hailong-am
Copy link
Collaborator

@MadaniKK could you fix the DOC check https://github.com/opensearch-project/opensearch-dashboards-functional-test/pull/912/checks?check_run_id=17497953466

Hi. Yes, but I am confused about what name and email we can use for signing off... I did sign off the commit, but just with a different name and email. I used the same name and email for sign-off when contributing to other OpenSearch repos. I found out other OpenSearch repos only require all commits to be signed off but don't specify the name and the email has to be "@users.noreply.github.com". Do I need to change my local git config to that name and email?

can you check your email settings of github with link https://github.com/settings/emails, that should be the same one with signing off

I just checked, It is actually the same email but in my GitHub email setting, I enabled "Keep my email addresses private". Now I disabled it, also I changed my GitHub profile name to match the local git config. I think now it should be able to pass the DCO check... Is there a way to trigger the DCO check again?

can you try with following steps as suggested

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~1 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin backport/backport-908-to-2.x

@MadaniKK
Copy link
Contributor

MadaniKK commented Oct 8, 2023

3. git push --force-with-lease origin backport/backport-908-to-2.x

I got this error
image
it's possible that I did not the check out pull request locally correctly, I am a little bit confused about "getting a local copy"
so what I did was:
I ran the git rebase HEAD~1 --signoff and git push --force-with-lease origin backport/backport-908-to-2.x commands

@Hailong-am
Copy link
Collaborator

I am a little bit confused about "getting a local copy"

To get a local copy of this PR run gh pr checkout 912. However i am not sure you have permission to push changes to branch backport/backport-908-to-2.x directly and I have set DCO as passed manually this time.

@MadaniKK
Copy link
Contributor

MadaniKK commented Oct 8, 2023

I am a little bit confused about "getting a local copy"

To get a local copy of this PR run gh pr checkout 912. However i am not sure you have permission to push changes to branch backport/backport-908-to-2.x directly and I have set DCO as passed manually this time.

Thank you so much!!

@Hailong-am Hailong-am merged commit 45a334b into 2.x Oct 9, 2023
38 of 40 checks passed
@github-actions github-actions bot deleted the backport/backport-908-to-2.x branch October 9, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants