Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] update installation commands in DEVELOPER_GUIDE.md #908

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

MadaniKK
Copy link
Contributor

@MadaniKK MadaniKK commented Oct 5, 2023

Description

These commands were not working:
yarn cypress run-without-security --spec "cypress/integration/core-opensearch-dashboards/vanilla-opensearch-dashboards/*.js"
yarn cypress run-with-security --spec "cypress/integration/core-opensearch-dashboards/opensearch-dashboards/*.js"

now changed to:
yarn cypress:run-without-security --spec "cypress/integration/core-opensearch-dashboards/vanilla-opensearch-dashboards/*.js"
yarn cypress:run-with-security --spec "cypress/integration/core-opensearch-dashboards/opensearch-dashboards/*.js"

Issues Resolved

Issue #907

Check List

  • [ ☑️] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: qiwen li <qiwen_li@brown.edu>
@Hailong-am Hailong-am merged commit e53ba8e into opensearch-project:main Oct 8, 2023
37 of 38 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 8, 2023
Signed-off-by: qiwen li <qiwen_li@brown.edu>
(cherry picked from commit e53ba8e)
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-908-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e53ba8e9071de78410deb0be8a964236fe040f21
# Push it to GitHub
git push --set-upstream origin backport/backport-908-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-908-to-2.x.

Hailong-am pushed a commit that referenced this pull request Oct 9, 2023
Signed-off-by: qiwen li <qiwen_li@brown.edu>
(cherry picked from commit e53ba8e)

Co-authored-by: Riley Li <71857976+MadaniKK@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants