Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enhancement check in case bot account has no write access on repos #1988

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

zelinh
Copy link
Member

@zelinh zelinh commented Apr 18, 2022

Signed-off-by: Zelin Hao zelinhao@amazon.com

Description

Add additional check when creating release tag after each release.
Old workflow used to fail immediately if bot account doesn't have write access on one specific repos. If it doesn't have write access on a number of repos, it will fail each time when the access issue happens.

This enhancement will store the repo names in a list and continue with other repos if the bot account doesn't have access on some repos. The entire job will still fail but provide a list of all the untagged repo names while all other tags created on the rest of them on the manifest.

Issues Resolved

#1860

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
@zelinh zelinh self-assigned this Apr 18, 2022
@zelinh zelinh requested a review from a team as a code owner April 18, 2022 22:52
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2022

Codecov Report

Merging #1988 (f610a53) into main (7c732e9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1988   +/-   ##
=========================================
  Coverage     94.41%   94.41%           
  Complexity       22       22           
=========================================
  Files           187      187           
  Lines          3739     3739           
  Branches         29       29           
=========================================
  Hits           3530     3530           
  Misses          203      203           
  Partials          6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c732e9...f610a53. Read the comment docs.

@dblock dblock merged commit 4fa9127 into opensearch-project:main Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants