Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Improve tag creation pipeline to skip repositories without write permission for the bot account #1860

Closed
peterzhuamazon opened this issue Mar 30, 2022 · 5 comments
Assignees
Labels
cicd enhancement New Enhancement

Comments

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Mar 30, 2022

As of now, the release tag creation will fail the build if the bot account does not have permission to write in any repository.

This requires our team member with access to manually create a tag on those repos.

We should let the pipeline skip these repos, and output a list of repos that requires to add the bot with write access, and we can manually create the tags after the release pipeline run.

Acceptance Criteria

  • We would want to create tags for all repositories, if creation fails, the repository should be skipped and continue for the remaining repositories. The job should then fail listing down the failed repositories.
@peterzhuamazon peterzhuamazon added enhancement New Enhancement cicd labels Mar 30, 2022
@peterzhuamazon peterzhuamazon added the untriaged Issues that have not yet been triaged label Mar 30, 2022
@dblock
Copy link
Member

dblock commented Mar 31, 2022

I think it's a bad idea. Permissions should be fixed anyway, and the workflow can be rerun as many times as needed as it skips correct existing tags. If you stop failing it, we'll never know that permissions are missing.

@bbarani
Copy link
Member

bbarani commented Mar 31, 2022

@dblock We are not going to stop failing rather we dont want the process to terminate in the middle of the tagging process when it doesn't have access to any specific repo. The job will still fail listing the repos that has issue but it will create tags on other repos not affected by access issues.

@zelinh
Copy link
Member

zelinh commented Mar 31, 2022

If the pipeline failed, we should always rerun the workflow to make sure tags are successfully created on other components until the job passes.
One drawback of current workflow I think is that we will need to rerun the job more than 2 times if there are multiple repos that bot doesn't have write access on.

@abhinavGupta16
Copy link
Contributor

[triage] We would want to create tags for all repositories, if creation fails, the repository should be skipped and continue for the remaining repositories. The job should then fail listing down the failed repositories.

@abhinavGupta16 abhinavGupta16 removed the untriaged Issues that have not yet been triaged label Apr 5, 2022
@zelinh
Copy link
Member

zelinh commented Apr 20, 2022

Closing this issue as this enhancement have been implemented with PR linked above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cicd enhancement New Enhancement
Projects
None yet
Development

No branches or pull requests

5 participants