fix the status check of service in cluster #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tianle Huang <tianleh@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #1166 +/- ##
=========================================
Coverage 93.75% 93.75%
Complexity 10 10
=========================================
Files 103 103
Lines 2563 2563
Branches 9 9
=========================================
Hits 2403 2403
Misses 150 150
Partials 10 10
Continue to review full report at Codecov.
|
seraphjiang
approved these changes
Nov 27, 2021
dblock
approved these changes
Nov 27, 2021
| @@ -68,7 +68,7 @@ def get_service_response(self): | |||
| def service_alive(self): | |||
| response = self.get_service_response() | |||
| logging.info(f"{response.status_code}: {response.text}") | |||
| if response.status_code == 200 and ('"status":"green"' or '"status":"yellow"' in response.text): | |||
| if response.status_code == 200 and (('"status":"green"' in response.text) or ('"status":"yellow"' in response.text)): | |||
There was a problem hiding this comment.
The service response is a JSON. To future proof this, there should be a class that wraps it, and exposes it’s properties, including an .alive method.
tianleh
added
the
comment-to-followup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tianle Huang tianleh@amazon.com
Description
fix the status check of service in cluster
Issues Resolved
Resolves #1165
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.