Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle status response with a Class during sevice readiness check #1217

Closed
tianleh opened this issue Dec 1, 2021 · 5 comments
Closed

Handle status response with a Class during sevice readiness check #1217

tianleh opened this issue Dec 1, 2021 · 5 comments
Assignees
Labels

Comments

@tianleh
Copy link
Member

tianleh commented Dec 1, 2021

Is your feature request related to a problem? Please describe

#604

A follow up of @dblock 's PR comment #1166 (comment)

Describe the solution you'd like

handle the json with Class

Describe alternatives you've considered

No response

Additional context

No response

@tianleh tianleh added enhancement New Enhancement untriaged Issues that have not yet been triaged labels Dec 1, 2021
@tianleh tianleh self-assigned this Dec 1, 2021
@tianleh tianleh added ci-test-automation and removed untriaged Issues that have not yet been triaged labels Dec 1, 2021
@ohltyler
Copy link
Member

ohltyler commented Jan 21, 2022

@tianleh what about using the number_of_pending_tasks field to determine cluster readiness? For example, I've seen integ tests occasionally fail due to missing indices. It seems looks the cluster health reports as yellow (which right now means available to run the tests) but has a number_of_pending_tasks > 0 (see here), which is likely the culprit for these flaky failures

@tianleh
Copy link
Member Author

tianleh commented Jan 24, 2022

@ohltyler Totally make sense! I am focusing on #1492 and #1372 and do not have resources to take this current issue in the near future. Feel free to address it if it is urgent.

@bbarani
Copy link
Member

bbarani commented Nov 21, 2022

@ohltyler @tianleh Do you have any update on this issue?

@bbarani
Copy link
Member

bbarani commented Jan 30, 2023

@ohltyler @tianleh @seraphjiang Do you have any update on this issue?

@rishabh6788
Copy link
Collaborator

@ohltyler It seems the cluster verification has been working fine for a while and we have tests to make sure the cluster is up before we start the tests.
Closing this issue. Feel free to open new issue if you are still seeing flaky errors due to cluster readiness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants