Revert "amending tests to include all codecs (#8907)"

[reta]

This reverts commit c43743d.

Description

Revert "amending tests to include all codecs (#8907)", causing random failures for completion suggesters

Failed to execute phase [query], all shards failed; shardFailures {[xjSEU8WnRrWqVEA7XUuBEQ][vfvppfjpmz][0]: RemoteTransportException[[node_s1][127.0.0.1:45533][indices:data/read/search[phase/query]]]; nested: IllegalArgumentException[lpvzbmxouw is not a SuggestField]; }
	at __randomizedtesting.SeedInfo.seed([D6593E046E320B3C:D9803AA8A4A760E9]:0)
	at app//org.opensearch.action.search.AbstractSearchAsyncAction.onPhaseFailure(AbstractSearchAsyncAction.java:677)
	at app//org.opensearch.action.search.AbstractSearchAsyncAction.executeNextPhase(AbstractSearchAsyncAction.java:373)
	at app//org.opensearch.action.search.AbstractSearchAsyncAction.onPhaseDone(AbstractSearchAsyncAction.java:716)
	at app//org.opensearch.action.search.AbstractSearchAsyncAction.onShardFailure(AbstractSearchAsyncAction.java:485)
	at app//org.opensearch.action.search.AbstractSearchAsyncAction$1.onFailure(AbstractSearchAsyncAction.java:295)
	at app//org.opensearch.action.search.SearchExecutionStatsCollector.onFailure(SearchExecutionStatsCollector.java:104)
	at app//org.opensearch.action.ActionListenerResponseHandler.handleException(ActionListenerResponseHandler.java:74)
	at app//org.opensearch.action.search.SearchTransportService$ConnectionCountingHandler.handleException(SearchTransportService.java:749)

See please https://build.ci.opensearch.org/job/gradle-check/21267 and #8963

Related Issues

Closes #8966

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[reta]

@sarthakaggarwal97 I have to revert the change for now, I have not figured out exactly what is happening but the tests are failing because of the wrong posting format that is coming from the codec. We will get back to that but massive flaky tests fail the builds.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/21278/
• CommitID: 8ac66a8
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[reta]

@nknize another source of flakyness (it looks like)

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/21279/
• CommitID: f2b4863

[codecov]

Codecov Report

Merging #8968 (f2b4863) into main (c43743d) will decrease coverage by 0.16%.
Report is 3 commits behind head on main.
The diff coverage is 44.44%.

@@             Coverage Diff              @@
##               main    #8968      +/-   ##
============================================
- Coverage     71.17%   71.01%   -0.16%     
+ Complexity    57284    57226      -58     
============================================
  Files          4759     4759              
  Lines        269881   269885       +4     
  Branches      39488    39489       +1     
============================================
- Hits         192078   191654     -424     
- Misses        61601    62068     +467     
+ Partials      16202    16163      -39     

Files Changed	Coverage Δ
...ex/translog/transfer/TranslogTransferMetadata.java	84.61% <ø> (ø)
...search/suggest/completion/CompletionSuggester.java	2.56% <0.00%> (-0.22%)	⬇️
...ex/translog/transfer/BlobStoreTransferService.java	88.88% <100.00%> (ø)
...dex/translog/transfer/TranslogTransferManager.java	77.94% <100.00%> (ø)
...ensearch/search/internal/ContextIndexSearcher.java	67.83% <100.00%> (-0.40%)	⬇️

... and 439 files with indirect coverage changes

[sarthakaggarwal97]

noted @reta, will look into this
Thanks for proactively reverting this!

[sarthakaggarwal97]

@reta @nknize figured out the issue
In the commit, I added lucene_default codec which internally maps to Asserting codec. We have not provisioned an override for this codec with PerFieldMappingPostingFormatCodec for the completion field.
I will raise another PR excluding this codec from the list, as we don't really support this codec for the users as well.

[reta]

In the commit, I added lucene_default codec which internally maps to Asserting codec. We have not provisioned an override for this codec with PerFieldMappingPostingFormatCodec for the completion field.

Thanks @sarthakaggarwal97 that sound like the reasons and aligned with what was observed for tests that fail