Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend tests to include all codecs #8907

Merged

Conversation

sarthakaggarwal97
Copy link
Contributor

@sarthakaggarwal97 sarthakaggarwal97 commented Jul 27, 2023

Description

Adds additional codecs to the tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sarthakaggarwal97 sarthakaggarwal97 changed the title amending tests to include all codecs Amend tests to include all codecs Jul 27, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@Poojita-Raj
Copy link
Contributor

There are 3 simultaneous PRs around the new codec introductions that I see: #8737, #8745 and this one (#8907). Is there a meta issue detailing why these changes are being made?

I think they should all be linked to a meta to let reviewers see the larger context and the order in which these PRs should be reviewed and merged in.

@sarthakaggarwal97
Copy link
Contributor Author

@Poojita-Raj these three PR's are majorly for refactoring few things related to compression codecs and their settings. All of which are independent of each other. I don't think a meta issue was required for such refactors.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #8907 (600e0c2) into main (3952d5e) will decrease coverage by 0.13%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #8907      +/-   ##
============================================
- Coverage     71.12%   70.99%   -0.13%     
+ Complexity    57212    57204       -8     
============================================
  Files          4759     4759              
  Lines        269881   269881              
  Branches      39488    39488              
============================================
- Hits         191943   191606     -337     
- Misses        61752    62133     +381     
+ Partials      16186    16142      -44     

see 465 files with indirect coverage changes

@sarthakaggarwal97 sarthakaggarwal97 marked this pull request as ready for review July 28, 2023 06:09
@shwetathareja shwetathareja added the backport 2.x Backport to 2.x branch label Jul 28, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8907-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c43743dd8ac132314dfe375f712c37a7a0f7d8df
# Push it to GitHub
git push --set-upstream origin backport/backport-8907-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8907-to-2.x.

sarthakaggarwal97 added a commit to sarthakaggarwal97/OpenSearch that referenced this pull request Jul 28, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
(cherry picked from commit c43743d)
sarthakaggarwal97 added a commit to sarthakaggarwal97/OpenSearch that referenced this pull request Jul 28, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
(cherry picked from commit c43743d)
reta added a commit to reta/OpenSearch that referenced this pull request Jul 28, 2023
reta added a commit to reta/OpenSearch that referenced this pull request Jul 28, 2023
This reverts commit c43743d.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
kotwanikunal pushed a commit that referenced this pull request Jul 28, 2023
This reverts commit c43743d.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 28, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 28, 2023
…" (opensearch-project#8968)

This reverts commit c43743d.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 28, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 28, 2023
…" (opensearch-project#8968)

This reverts commit c43743d.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
…" (opensearch-project#8968)

This reverts commit c43743d.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
…" (opensearch-project#8968)

This reverts commit c43743d.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
…" (opensearch-project#8968)

This reverts commit c43743d.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
sarthakaggarwal97 added a commit to sarthakaggarwal97/OpenSearch that referenced this pull request Jul 29, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
(cherry picked from commit c43743d)
@Poojita-Raj Poojita-Raj mentioned this pull request Jul 31, 2023
3 tasks
sarthakaggarwal97 added a commit to sarthakaggarwal97/OpenSearch that referenced this pull request Aug 2, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
reta pushed a commit that referenced this pull request Aug 2, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
…" (opensearch-project#8968)

This reverts commit c43743d.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
…" (opensearch-project#8968)

This reverts commit c43743d.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…" (opensearch-project#8968)

This reverts commit c43743d.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants