Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Segment Replication] Refactor RemoteStoreReplicationSource #8767

Merged
merged 26 commits into from
Aug 2, 2023
Merged

[Segment Replication] Refactor RemoteStoreReplicationSource #8767

merged 26 commits into from
Aug 2, 2023

Commits on Aug 1, 2023

  1. [Segment Replication] Refactor remote replication source 

    Signed-off-by: Suraj Singh <surajrider@gmail.com>
    @dreamer-89
    dreamer-89 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    c04190e View commit details
    Browse the repository at this point in the history

  2. Unit test updates 

    Signed-off-by: Suraj Singh <surajrider@gmail.com>
    @dreamer-89
    dreamer-89 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    2d57ddc View commit details
    Browse the repository at this point in the history

  3. Self review 

    Signed-off-by: Suraj Singh <surajrider@gmail.com>
    @dreamer-89
    dreamer-89 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    929d824 View commit details
    Browse the repository at this point in the history

  4. Self review 

    Signed-off-by: Suraj Singh <surajrider@gmail.com>
    @dreamer-89
    dreamer-89 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    eb29746 View commit details
    Browse the repository at this point in the history

  5. Segregate shard level tests for node to node and remote store segment… 

    … replication

Signed-off-by: Suraj Singh <surajrider@gmail.com>
    @dreamer-89
    dreamer-89 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    60126e5 View commit details
    Browse the repository at this point in the history

  6. Fix failing unit tests 

    Signed-off-by: Suraj Singh <surajrider@gmail.com>
    @dreamer-89
    dreamer-89 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    5d9063a View commit details
    Browse the repository at this point in the history

  7. Fix failing UT 

    Signed-off-by: Suraj Singh <surajrider@gmail.com>
    @dreamer-89
    dreamer-89 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    7200dcb View commit details
    Browse the repository at this point in the history

  8. Fix failing UT 

    Signed-off-by: Suraj Singh <surajrider@gmail.com>
    @dreamer-89
    dreamer-89 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    8c92bc3 View commit details
    Browse the repository at this point in the history

  9. Address review comments 

    Signed-off-by: Suraj Singh <surajrider@gmail.com>
    @dreamer-89
    dreamer-89 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    49cabde View commit details
    Browse the repository at this point in the history

  10. Fix more unit tests 

    Signed-off-by: Suraj Singh <surajrider@gmail.com>
    @dreamer-89
    dreamer-89 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    2ce7e63 View commit details
    Browse the repository at this point in the history

  11. Improve RemoteStoreReplicationSourceTests, remove unnecessary mocks a… 

    …nd use actual failures for failure/exception use cases

Signed-off-by: Suraj Singh <surajrider@gmail.com>
    @dreamer-89
    dreamer-89 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    04ad07c View commit details
    Browse the repository at this point in the history

  12. Spotless check fix 

    Signed-off-by: Suraj Singh <surajrider@gmail.com>
    @dreamer-89
    dreamer-89 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    d537a4e View commit details
    Browse the repository at this point in the history

  13. Address review comments 

    Signed-off-by: Suraj Singh <surajrider@gmail.com>
    @dreamer-89
    dreamer-89 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    dfdc7cc View commit details
    Browse the repository at this point in the history

  14. Ignore files already in store while computing segment file diff with … 

    …primary

Signed-off-by: Suraj Singh <surajrider@gmail.com>
    @dreamer-89
    dreamer-89 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    b53b4b4 View commit details
    Browse the repository at this point in the history

  15. Spotless fix 

    Signed-off-by: Suraj Singh <surajrider@gmail.com>
    @dreamer-89
    dreamer-89 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    7b1b6ff View commit details
    Browse the repository at this point in the history

  16. Fix failing UT 

    Signed-off-by: Suraj Singh <surajrider@gmail.com>
    @dreamer-89
    dreamer-89 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    6ceaf1d View commit details
    Browse the repository at this point in the history

  17. Spotless fix 

    Signed-off-by: Suraj Singh <surajrider@gmail.com>
    @dreamer-89
    dreamer-89 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    90e4bc8 View commit details
    Browse the repository at this point in the history

  18. Move read/writes from IndexInput/Output to RemoteSegmentMetadata 

    Signed-off-by: Suraj Singh <surajrider@gmail.com>
    @dreamer-89
    dreamer-89 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    ac59af9 View commit details
    Browse the repository at this point in the history

  19. Address review commnt 

    Signed-off-by: Suraj Singh <surajrider@gmail.com>
    @dreamer-89
    dreamer-89 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    bc9bd8c View commit details
    Browse the repository at this point in the history

  20. Update recovery flow to perform commits during recovery 

    Signed-off-by: Suraj Singh <surajrider@gmail.com>
    @dreamer-89
    dreamer-89 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    1689fd2 View commit details
    Browse the repository at this point in the history

  21. Remove un-necessary char 

    Signed-off-by: Suraj Singh <surajrider@gmail.com>
    @dreamer-89
    dreamer-89 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    dc79593 View commit details
    Browse the repository at this point in the history

  22. Address review comments 

    Signed-off-by: Suraj Singh <surajrider@gmail.com>
    @dreamer-89
    dreamer-89 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    330e712 View commit details
    Browse the repository at this point in the history

  23. Update comment nit-pick 

    Signed-off-by: Suraj Singh <surajrider@gmail.com>
    @dreamer-89
    dreamer-89 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    0ac181a View commit details
    Browse the repository at this point in the history

  24. Remove deletion logic causing read issues due to deleted segments_N 

    Signed-off-by: Suraj Singh <surajrider@gmail.com>
    @dreamer-89
    dreamer-89 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    4337dcd View commit details
    Browse the repository at this point in the history

  25. Spotless fix 

    Signed-off-by: Suraj Singh <surajrider@gmail.com>
    @dreamer-89
    dreamer-89 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    14ca8ed View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Fix unit tests 

    Signed-off-by: Suraj Singh <surajrider@gmail.com>
    @dreamer-89
    dreamer-89 committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    753729c View commit details
    Browse the repository at this point in the history