Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Use DirectoryFactory interface to create remote directory #6985

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 56a2bed from #6970.

* Use DirectoryFactory interface to create remote directory

Signed-off-by: Sachin Kale <kalsac@amazon.com>

* Fix tests

Signed-off-by: Sachin Kale <kalsac@amazon.com>

---------

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
(cherry picked from commit 56a2bed)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=pit/10_basic/Delete all}

@codecov-commenter
Copy link

Codecov Report

Merging #6985 (b196c8f) into 2.x (068ec12) will increase coverage by 0.01%.
The diff coverage is 80.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x    #6985      +/-   ##
============================================
+ Coverage     70.38%   70.39%   +0.01%     
- Complexity    59505    59541      +36     
============================================
  Files          4811     4811              
  Lines        285577   285577              
  Branches      41516    41516              
============================================
+ Hits         200997   201043      +46     
+ Misses        67835    67808      -27     
+ Partials      16745    16726      -19     
Impacted Files Coverage Δ
...rc/main/java/org/opensearch/index/IndexModule.java 81.92% <ø> (ø)
...c/main/java/org/opensearch/index/IndexService.java 74.04% <0.00%> (-0.29%) ⬇️
...in/java/org/opensearch/indices/IndicesService.java 64.09% <ø> (-0.15%) ⬇️
.../java/org/opensearch/plugins/IndexStorePlugin.java 100.00% <ø> (ø)
...pensearch/action/search/SearchPhaseController.java 85.14% <100.00%> (ø)
...ndex/store/RemoteSegmentStoreDirectoryFactory.java 94.73% <100.00%> (+0.29%) ⬆️
server/src/main/java/org/opensearch/node/Node.java 83.64% <100.00%> (ø)

... and 469 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kotwanikunal kotwanikunal merged commit c89a2e3 into 2.x Apr 5, 2023
@github-actions github-actions bot deleted the backport/backport-6970-to-2.x branch April 5, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants