Use DirectoryFactory interface to create remote directory #6970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
sachinpkale
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
Gradle Check (Jenkins) Run Completed with:
|
andrross
approved these changes
Apr 4, 2023
There was a problem hiding this comment.
Thanks @sachinpkale! I actually noticed this a couple months ago so thanks for doing this.
Is it possible/is there a plan to evolve this code so that IndexService doesn't need to hold two directory factories and a single implementation can do the local+remote mirroring functionality offered by the two factories now?
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 4, 2023
* Use DirectoryFactory interface to create remote directory Signed-off-by: Sachin Kale <kalsac@amazon.com> * Fix tests Signed-off-by: Sachin Kale <kalsac@amazon.com> --------- Signed-off-by: Sachin Kale <kalsac@amazon.com> Co-authored-by: Sachin Kale <kalsac@amazon.com> (cherry picked from commit 56a2bed) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal
pushed a commit
that referenced
this pull request
Apr 5, 2023
mitrofmep
pushed a commit
to mitrofmep/OpenSearch
that referenced
this pull request
Apr 5, 2023
…-project#6970) * Use DirectoryFactory interface to create remote directory Signed-off-by: Sachin Kale <kalsac@amazon.com> * Fix tests Signed-off-by: Sachin Kale <kalsac@amazon.com> --------- Signed-off-by: Sachin Kale <kalsac@amazon.com> Co-authored-by: Sachin Kale <kalsac@amazon.com> Signed-off-by: Valentin Mitrofanov <mitrofmep@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RemoteDirectoryFactoryinterface to create an instance ofRemoteDirectory.Repositoryinstance as an input. But in [Remote Store] Inject remote store in IndexShard instead of RemoteStoreRefreshListener #3703, we changed the parameter type fromRepositorytoString(repository name).DirectoryFactoryinterface,RemoteDirectoryFactorybecomes redundant.Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.