[Weighted Routing] Weighted routing metadata to support multiple awareness attributes #5580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
added 2 commits
December 16, 2022 15:20
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
added 2 commits
December 19, 2022 10:40
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
anshu1106
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
adnapibar,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89 and
tlfeng
as code owners
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
imRishN
reviewed
Dec 19, 2022
| @@ -35,7 +35,7 @@ public class RestClusterDeleteWeightedRoutingAction extends BaseRestHandler { | |||
|
|
|||
| @Override | |||
| public List<Route> routes() { | |||
| return singletonList(new Route(DELETE, "/_cluster/routing/awareness/weights")); | |||
| return singletonList(new Route(DELETE, "/_cluster/routing/awareness/{attribute}/weights")); | |||
There was a problem hiding this comment.
This change is backward incompatible since we have already released the above API in 2.3? Either we keep both or just the first one?
There was a problem hiding this comment.
This api is marked as experimental in 2.4, so I guess we can have breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anshu Agarwal anshukag@amazon.com
Description
Currently as part of delete weighted routing api call, weighted routing metadata is cleared off completely from the cluster state without matching the awareness attribute. If weights are set for multiple awareness attributes, then this is not desirable.
This PR adds support for updating weights for multiple awareness attribute and delete specific awareness attribute weights.
Issues Resolved
#4747
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.