Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG][Discover] Enable 'Back to Top' Feature in Discover for scrolling to top #6008

Merged
merged 2 commits into from
Mar 4, 2024
Merged

[BUG][Discover] Enable 'Back to Top' Feature in Discover for scrolling to top #6008

merged 2 commits into from
Mar 4, 2024

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Mar 3, 2024 •
edited
Loading

Description

dscCanvas is the one with scrollable prop. Set window.scrollTo(0, 0) on table will not work. In this PR, we add a ref to EuiPanel directly.

Issues Resolved

#6006

Screenshot

backtotop.mov

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@ananzh
Copy link
Member Author

ananzh commented Mar 4, 2024

Add Function Test Suite 11: Infinity Scroll in Legacy Table in #5713 to function meta issue.
We will add a new test suite in the functional test repo to test this bug.

@ananzh ananzh mentioned this pull request Mar 4, 2024
Closed
7 tasks
@ananzh
[BUG][Discover] Enable 'Back to Top' Feature in Discover for scrollin…
ed8412c 
…g to top

dscCanvas is the one with scrollable prop. Set window.scrollTo(0, 0) on table will
not work. In this PR, we add a ref to EuiPanel directly.

Issue Resolve:
opensearch-project#6006

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh marked this pull request as ready for review March 4, 2024 01:58
@ananzh ananzh changed the title Fix 6007 in another way [BUG][Discover] Enable 'Back to Top' Feature in Discover for scrolling to top Mar 4, 2024
AMoo-Miki
AMoo-Miki reviewed Mar 4, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@ananzh @AMoo-Miki
Update CHANGELOG.md
780f0bf 
Co-authored-by: Miki <amoo_miki@yahoo.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ashwin-pc
ashwin-pc approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally I'd pass the panel ref down the tree instead of the function itself since a ref will not cause any rerenders and can be used for other purposes as well. If you can change the prop being sent down to that, let's do it.

@ananzh
Copy link
Member Author

ananzh commented Mar 4, 2024

Ideally I'd pass the panel ref down the tree instead of the function itself since a ref will not cause any rerenders and can be used for other purposes as well. If you can change the prop being sent down to that, let's do it.

k. let me try it.

@ananzh ananzh merged commit d407f55 into opensearch-project:main Mar 4, 2024
14 checks passed
@ananzh ananzh added bug Something isn't working discover for discover reinvent v2.13.0 backport 2.x labels Mar 4, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 4, 2024
@github-actions
[BUG][Discover] Enable 'Back to Top' Feature in Discover for scrollin…
c8337ad 
…g to top (#6008)

* [BUG][Discover] Enable 'Back to Top' Feature in Discover for scrolling to top

dscCanvas is the one with scrollable prop. Set window.scrollTo(0, 0) on table will
not work. In this PR, we add a ref to EuiPanel directly.

Issue Resolve:
#6006

---------

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
(cherry picked from commit d407f55)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 4, 2024
Merged
ananzh added a commit that referenced this pull request Mar 4, 2024
@ananzh @AMoo-Miki
[BUG][Discover] Enable 'Back to Top' Feature in Discover for scrollin…
8ea6078 
…g to top (#6008)

* [BUG][Discover] Enable 'Back to Top' Feature in Discover for scrolling to top

dscCanvas is the one with scrollable prop. Set window.scrollTo(0, 0) on table will
not work. In this PR, we add a ref to EuiPanel directly.

Issue Resolve:
#6006

---------

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
ashwin-pc pushed a commit that referenced this pull request Mar 18, 2024
@opensearch-trigger-bot @github-actions
[BUG][Discover] Enable 'Back to Top' Feature in Discover for scrollin…
98dfac8 
…g to top (#6008) (#6011)

* [BUG][Discover] Enable 'Back to Top' Feature in Discover for scrolling to top

dscCanvas is the one with scrollable prop. Set window.scrollTo(0, 0) on table will
not work. In this PR, we add a ref to EuiPanel directly.

Issue Resolve:
#6006

---------

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
(cherry picked from commit d407f55)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@Tostti Tostti mentioned this pull request Apr 4, 2024
Closed
4 tasks
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Apr 7, 2024
@ananzh @AMoo-Miki @SuZhou-Joe
[BUG][Discover] Enable 'Back to Top' Feature in Discover for scrollin…
c8d4966 
…g to top (opensearch-project#6008)

* [BUG][Discover] Enable 'Back to Top' Feature in Discover for scrolling to top

dscCanvas is the one with scrollable prop. Set window.scrollTo(0, 0) on table will
not work. In this PR, we add a ref to EuiPanel directly.

Issue Resolve:
opensearch-project#6006

---------

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
SuZhou-Joe pushed a commit to ruanyl/OpenSearch-Dashboards that referenced this pull request Apr 7, 2024
@ananzh @AMoo-Miki @SuZhou-Joe
[BUG][Discover] Enable 'Back to Top' Feature in Discover for scrollin…
9c7de97 
…g to top (opensearch-project#6008)

* [BUG][Discover] Enable 'Back to Top' Feature in Discover for scrolling to top

dscCanvas is the one with scrollable prop. Set window.scrollTo(0, 0) on table will
not work. In this PR, we add a ref to EuiPanel directly.

Issue Resolve:
opensearch-project#6006

---------

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AMoo-Miki AMoo-Miki AMoo-Miki approved these changes

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@Flyingliuhub Flyingliuhub Flyingliuhub approved these changes

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@kristenTian kristenTian Awaiting requested review from kristenTian

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@BSFishy BSFishy Awaiting requested review from BSFishy

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

Assignees
No one assigned
Labels
backport 2.x bug Something isn't working discover for discover reinvent distinguished-contributor v2.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ananzh @AMoo-Miki @ashwin-pc @Flyingliuhub