Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG][Discover] Back to top does not work #6006

Closed
ananzh opened this issue Mar 3, 2024 · 0 comments
Closed

[BUG][Discover] Back to top does not work #6006

ananzh opened this issue Mar 3, 2024 · 0 comments
Labels
bug Something isn't working discover for discover reinvent v2.13.0

Comments

@ananzh
Copy link
Member

ananzh commented Mar 3, 2024

Describe the bug
Click Back to top in Discover does not go back to the top of Discover table.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Discover
  2. Load sample eCommerce data and set time range to last 5 days. Make sure there are more than 500 data. If not, set a longer time period.
  3. Scroll down Discover table till end.
  4. Click Back to top
  5. See error.

Expected behavior
Click Back to top in Discover should go back to the top of Discover table.

OpenSearch Version
main, 2.12

Dashboards Version
main, 2.12
@ananzh ananzh added bug Something isn't working untriaged discover for discover reinvent and removed untriaged labels Mar 3, 2024
@ananzh ananzh added v2.13.0 and removed untriaged labels Mar 3, 2024
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Mar 3, 2024
@ananzh
[BUG] Allow clicking back to top in Discover
c8e9cdb 
The original window.scrollTo(0, 0) will reset the window back but not
table. In this PR, we add a table wrapper to allow scroll back on table.

Issue Resolve:
opensearch-project#6006

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh mentioned this issue Mar 3, 2024
Closed
7 tasks
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Mar 3, 2024
@ananzh
[BUG][Discover] Enable 'Back to Top' Feature in Discover for scrollin…
0fda8bb 
…g to top

The original window.scrollTo(0, 0) will reset the window back but not
table. In this PR, we add a table wrapper to allow scroll back on table.

Issue Resolve:
opensearch-project#6006

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh mentioned this issue Mar 3, 2024
Open
11 tasks
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Mar 4, 2024
@ananzh
[BUG][Discover] Enable 'Back to Top' Feature in Discover for scrollin…
0dee0d0 
…g to top

dscCanvas is the one with scrollable prop. Set window.scrollTo(0, 0) on table will
not work. In this PR, we add a ref to EuiPanel directly.

Issue Resolve:
opensearch-project#6006

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh mentioned this issue Mar 4, 2024
Merged
7 tasks
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Mar 4, 2024
@ananzh
[BUG][Discover] Enable 'Back to Top' Feature in Discover for scrollin…
ed8412c 
…g to top

dscCanvas is the one with scrollable prop. Set window.scrollTo(0, 0) on table will
not work. In this PR, we add a ref to EuiPanel directly.

Issue Resolve:
opensearch-project#6006

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh closed this as completed in d407f55 Mar 4, 2024
opensearch-trigger-bot bot pushed a commit that referenced this issue Mar 4, 2024
@github-actions
[BUG][Discover] Enable 'Back to Top' Feature in Discover for scrollin…
c8337ad 
…g to top (#6008)

* [BUG][Discover] Enable 'Back to Top' Feature in Discover for scrolling to top

dscCanvas is the one with scrollable prop. Set window.scrollTo(0, 0) on table will
not work. In this PR, we add a ref to EuiPanel directly.

Issue Resolve:
#6006

---------

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
(cherry picked from commit d407f55)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
ananzh added a commit that referenced this issue Mar 4, 2024
@ananzh @AMoo-Miki
[BUG][Discover] Enable 'Back to Top' Feature in Discover for scrollin…
8ea6078 
…g to top (#6008)

* [BUG][Discover] Enable 'Back to Top' Feature in Discover for scrolling to top

dscCanvas is the one with scrollable prop. Set window.scrollTo(0, 0) on table will
not work. In this PR, we add a ref to EuiPanel directly.

Issue Resolve:
#6006

---------

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
ashwin-pc pushed a commit that referenced this issue Mar 18, 2024
@opensearch-trigger-bot @github-actions
[BUG][Discover] Enable 'Back to Top' Feature in Discover for scrollin…
98dfac8 
…g to top (#6008) (#6011)

* [BUG][Discover] Enable 'Back to Top' Feature in Discover for scrolling to top

dscCanvas is the one with scrollable prop. Set window.scrollTo(0, 0) on table will
not work. In this PR, we add a ref to EuiPanel directly.

Issue Resolve:
#6006

---------

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
(cherry picked from commit d407f55)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this issue Apr 7, 2024
@ananzh @AMoo-Miki @SuZhou-Joe
[BUG][Discover] Enable 'Back to Top' Feature in Discover for scrollin…
c8d4966 
…g to top (opensearch-project#6008)

* [BUG][Discover] Enable 'Back to Top' Feature in Discover for scrolling to top

dscCanvas is the one with scrollable prop. Set window.scrollTo(0, 0) on table will
not work. In this PR, we add a ref to EuiPanel directly.

Issue Resolve:
opensearch-project#6006

---------

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
SuZhou-Joe pushed a commit to ruanyl/OpenSearch-Dashboards that referenced this issue Apr 7, 2024
@ananzh @AMoo-Miki @SuZhou-Joe
[BUG][Discover] Enable 'Back to Top' Feature in Discover for scrollin…
9c7de97 
…g to top (opensearch-project#6008)

* [BUG][Discover] Enable 'Back to Top' Feature in Discover for scrolling to top

dscCanvas is the one with scrollable prop. Set window.scrollTo(0, 0) on table will
not work. In this PR, we add a ref to EuiPanel directly.

Issue Resolve:
opensearch-project#6006

---------

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working discover for discover reinvent v2.13.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ananzh