[Backport 2.11] [BUG][Discover] Allow default columns settings #5271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://github.com/avatars/u/80134844?s=60&v=4){kind=small}
* [BUG][Discover] Allow default columns settings This is a missing functionality * When user sets up `Default columns` in advanced settings, discover should display default columns if the selected idp has the columns. * If selected idp has no such columns, display `_source` column. Issue Resolve #5246 Signed-off-by: ananzh <ananzh@amazon.com> * fix unit test Signed-off-by: ananzh <ananzh@amazon.com> --------- Signed-off-by: ananzh <ananzh@amazon.com> (cherry picked from commit b3104ce) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
added
bug
opensearch-trigger-bot
bot
added
Skip-Changelog
opensearch-trigger-bot
bot
requested review from
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub and
BSFishy
as code owners
ananzh
approved these changes
Oct 10, 2023
Codecov Report
@@ Coverage Diff @@
## 2.11 #5271 +/- ##
=======================================
Coverage 66.81% 66.81%
=======================================
Files 3284 3284
Lines 63146 63149 +3
Branches 10047 10048 +1
=======================================
+ Hits 42191 42194 +3
- Misses 18483 18484 +1
+ Partials 2472 2471 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joshuarrrr
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport b3104ce from #5261.