Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG][Discover] Allow default columns settings #5261

Merged
merged 2 commits into from
Oct 10, 2023
Merged

[BUG][Discover] Allow default columns settings #5261

merged 2 commits into from
Oct 10, 2023

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Oct 10, 2023 •
edited
Loading

Description

This is a missing functionality. In this PR we enables the following:

  • When user sets up Default columns in advanced settings, discover should display default columns if the selected idp has the columns.
  • If selected idp has no such columns, display _source column.

Issues Resolved

#5246

Screenshot

default-columns.mov

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@ananzh
[BUG][Discover] Allow default columns settings
4e05551 
This is a missing functionality
* When user sets up `Default columns` in advanced settings, discover should display
default columns if the selected idp has the columns.
* If selected idp has no such columns, display `_source` column.

Issue Resolve
opensearch-project#5246

Signed-off-by: ananzh <ananzh@amazon.com>
@ananzh ananzh added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry backport 2.x backport 2.11 discover for discover reinvent bug Something isn't working and removed distinguished-contributor labels Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023 •
edited
Loading

Codecov Report

Merging #5261 (05ee6cb) into main (1e980fa) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main    #5261      +/-   ##
==========================================
- Coverage   66.77%   66.77%   -0.01%     
==========================================
  Files        3284     3284              
  Lines       63092    63095       +3     
  Branches    10048    10049       +1     
==========================================
  Hits        42132    42132              
- Misses      18487    18489       +2     
- Partials     2473     2474       +1
Flag Coverage Δ
Linux_1 35.26% <0.00%> (-0.01%) ⬇️
Linux_2 55.24% <ø> (ø)
Linux_3 43.84% <60.00%> (-0.01%) ⬇️
Linux_4 35.36% <ø> (-0.01%) ⬇️
Windows_1 35.27% <0.00%> (-0.01%) ⬇️
Windows_2 55.20% <ø> (ø)
Windows_3 43.85% <60.00%> (-0.01%) ⬇️
Windows_4 35.36% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...pplication/view_components/utils/filter_columns.ts 100.00% <100.00%> (ø)
...lication/utils/state_management/discover_slice.tsx 42.42% <0.00%> (-2.74%) ⬇️

... and 1 file with indirect coverage changes

AMoo-Miki
AMoo-Miki previously approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@AMoo-Miki AMoo-Miki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@ananzh
fix unit test
05ee6cb 
Signed-off-by: ananzh <ananzh@amazon.com>
@ashwin-pc ashwin-pc merged commit b3104ce into opensearch-project:main Oct 10, 2023
58 of 59 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 10, 2023
@github-actions
[BUG][Discover] Allow default columns settings (#5261)
278d5a8 
* [BUG][Discover] Allow default columns settings

This is a missing functionality
* When user sets up `Default columns` in advanced settings, discover should display
default columns if the selected idp has the columns.
* If selected idp has no such columns, display `_source` column.

Issue Resolve
#5246

Signed-off-by: ananzh <ananzh@amazon.com>

* fix unit test

Signed-off-by: ananzh <ananzh@amazon.com>

---------

Signed-off-by: ananzh <ananzh@amazon.com>
(cherry picked from commit b3104ce)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 10, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 10, 2023
@github-actions
[BUG][Discover] Allow default columns settings (#5261)
b042b52 
* [BUG][Discover] Allow default columns settings

This is a missing functionality
* When user sets up `Default columns` in advanced settings, discover should display
default columns if the selected idp has the columns.
* If selected idp has no such columns, display `_source` column.

Issue Resolve
#5246

Signed-off-by: ananzh <ananzh@amazon.com>

* fix unit test

Signed-off-by: ananzh <ananzh@amazon.com>

---------

Signed-off-by: ananzh <ananzh@amazon.com>
(cherry picked from commit b3104ce)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 10, 2023
Merged
ashwin-pc pushed a commit that referenced this pull request Oct 10, 2023
@opensearch-trigger-bot @github-actions
[BUG][Discover] Allow default columns settings (#5261) (#5270)
2a31887 
* [BUG][Discover] Allow default columns settings

This is a missing functionality
* When user sets up `Default columns` in advanced settings, discover should display
default columns if the selected idp has the columns.
* If selected idp has no such columns, display `_source` column.

Issue Resolve
#5246



* fix unit test



---------


(cherry picked from commit b3104ce)

Signed-off-by: ananzh <ananzh@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ananzh pushed a commit that referenced this pull request Oct 10, 2023
@opensearch-trigger-bot @github-actions
[BUG][Discover] Allow default columns settings (#5261) (#5271)
3c83816 
* [BUG][Discover] Allow default columns settings

This is a missing functionality
* When user sets up `Default columns` in advanced settings, discover should display
default columns if the selected idp has the columns.
* If selected idp has no such columns, display `_source` column.

Issue Resolve
#5246

---------


(cherry picked from commit b3104ce)

Signed-off-by: ananzh <ananzh@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BSFishy BSFishy BSFishy approved these changes

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@AMoo-Miki AMoo-Miki AMoo-Miki left review comments

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@seanneumann seanneumann Awaiting requested review from seanneumann

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@kristenTian kristenTian Awaiting requested review from kristenTian

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

Assignees
No one assigned
Labels
backport 2.x bug Something isn't working discover for discover reinvent Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ananzh @AMoo-Miki @BSFishy @ashwin-pc