Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Make tests covering plugin installation on cluster snapshots work across platforms #2999

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport ed92158 from #2994.

…ross platforms (#2994)

Signed-off-by: Miki <amoo_miki@yahoo.com>

Signed-off-by: Miki <amoo_miki@yahoo.com>
(cherry picked from commit ed92158)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner December 1, 2022 19:46
@AMoo-Miki AMoo-Miki added the autocut Skip the changelog verification check on backports label Dec 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2022

Codecov Report

Merging #2999 (bc11b85) into 2.x (c292a9a) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              2.x    #2999      +/-   ##
==========================================
+ Coverage   66.67%   66.72%   +0.05%     
==========================================
  Files        3219     3219              
  Lines       61450    61450              
  Branches     9417     9417              
==========================================
+ Hits        40973    41005      +32     
+ Misses      18231    18204      -27     
+ Partials     2246     2241       -5     
Flag Coverage Δ
Linux 66.67% <ø> (-0.01%) ⬇️
Windows 66.68% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/osd-optimizer/src/node/node_auto_tranpilation.ts 83.67% <0.00%> (-4.09%) ⬇️
packages/osd-optimizer/src/node/cache.ts 51.31% <0.00%> (-1.32%) ⬇️
...ic/application/models/sense_editor/sense_editor.ts 64.88% <0.00%> (+0.88%) ⬆️
...ared/static/forms/hook_form_lib/hooks/use_field.ts 66.66% <0.00%> (+0.96%) ⬆️
src/dev/build/lib/config.ts 85.29% <0.00%> (+5.88%) ⬆️
...ges/osd-apm-config-loader/src/config.test.mocks.ts 100.00% <0.00%> (+8.69%) ⬆️
packages/osd-cross-platform/src/path.ts 85.36% <0.00%> (+34.14%) ⬆️
src/setup_node_env/harden/child_process.js 76.92% <0.00%> (+38.46%) ⬆️
src/dev/build/lib/get_build_number.ts 100.00% <0.00%> (+42.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see some scan copy test failures are they being addressed?

@AMoo-Miki
Copy link
Collaborator

i see some scan copy test failures are they being addressed?

They went in with #2978

@kavilla
Copy link
Member

kavilla commented Dec 1, 2022

Cool then I'm merging as is. Don't need to re-run.

@AMoo-Miki AMoo-Miki merged commit 96952e7 into 2.x Dec 1, 2022
@github-actions github-actions bot deleted the backport/backport-2994-to-2.x branch December 1, 2022 21:56
@joshuarrrr joshuarrrr added the v2.5.0 'Issues and PRs related to version v2.5.0' label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants