Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Build] Update folder timestamps after copying files into them using scanCopy #2978

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 5dc0212 from #2964.

…2964)

* When updating the timestamps were requested, scanCopy first set the times and then copied content into the destination folder. On certain platforms, copying files into a folder updates its "Last Access Time" and that overwrites the just set timestamps. This PR, makes sure the timestamps are set only after copying the content.

Signed-off-by: Miki <amoo_miki@yahoo.com>

Signed-off-by: Miki <amoo_miki@yahoo.com>
(cherry picked from commit 5dc0212)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner November 30, 2022 23:21
@codecov-commenter
Copy link

Codecov Report

Merging #2978 (6f00743) into 2.x (01da0af) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##              2.x    #2978   +/-   ##
=======================================
  Coverage   66.66%   66.67%           
=======================================
  Files        3219     3219           
  Lines       61448    61448           
  Branches     9417     9417           
=======================================
+ Hits        40967    40971    +4     
+ Misses      18234    18231    -3     
+ Partials     2247     2246    -1     
Impacted Files Coverage Δ
src/dev/build/lib/scan_copy.ts 17.85% <0.00%> (ø)
packages/osd-optimizer/src/node/cache.ts 52.63% <0.00%> (+2.63%) ⬆️
...s/osd-optimizer/src/node/node_auto_tranpilation.ts 87.75% <0.00%> (+4.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@AMoo-Miki AMoo-Miki added the autocut Skip the changelog verification check on backports label Dec 1, 2022
@AMoo-Miki AMoo-Miki merged commit d8f59f0 into 2.x Dec 1, 2022
@github-actions github-actions bot deleted the backport/backport-2964-to-2.x branch December 1, 2022 20:26
@joshuarrrr joshuarrrr added the v2.5.0 'Issues and PRs related to version v2.5.0' label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants