Add @zhongnansu as maintainer #2590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kristen Tian <tyarong@amazon.com>
|
@kristenTian Thanks for the PR. Can you also add the reason @zhongnansu was added as a maintainer to the PR description for future reference? e.g.opensearch-project/OpenSearch#3231 |
Sure thing, thanks for sharing. |
kavilla
approved these changes
Oct 18, 2022
ashwin-pc
approved these changes
Oct 18, 2022
|
Thank you! |
vimalMK
pushed a commit
to vimalMK/OpenSearch-Dashboards
that referenced
this pull request
Oct 20, 2022
Signed-off-by: Kristen Tian <tyarong@amazon.com> Signed-off-by: Kristen Tian <tyarong@amazon.com> Signed-off-by: vimal k <vimalinfo10@gmail.com>
sipopo
pushed a commit
to sipopo/OpenSearch-Dashboards
that referenced
this pull request
Dec 16, 2022
Signed-off-by: Kristen Tian <tyarong@amazon.com> Signed-off-by: Kristen Tian <tyarong@amazon.com> Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kristen Tian tyarong@amazon.com
Description
Zhongnan has kindly accepted the invitation, therefore adding @zhongnansu as maintainer.
Zhongnan has a lot of experience in the team with the project and as an external plugin developer which is what a lot of the core maintainers lack insight on, it would be great to get more of his insight on non-MD PRs with his previous experience.
Some of @zhongnansu 's contributions in the past:
[OSD] 17 submitted PRs: https://github.com/opensearch-project/OpenSearch-Dashboards/pulls/zhongnansu
[OSD] 51 PRs reviewed: https://github.com/opensearch-project/OpenSearch-Dashboards/issues?q=reviewed-by%3Azhongnansu
[OSD] 71 issues involved(authored and commented): https://github.com/opensearch-project/OpenSearch-Dashboards/issues?page=1&q=involves%3Azhongnansu+is%3Aissue
In MD project, planned and contributed client management module. See this meta issue for a list of the detailed work including Research, POC, enhancement, bug fix
Addressed CVE and CI issues during OSS oncall
o Fix CVE-2022-0686, add resolution for url-parse #2181
o Bump chrome driver version in PR check workflow #2186
First to submit the feature request of OSD demo site, which later turned into “Playground” project and released in 2.3.0
Zhongnan has experiences in Kibana/OSD plugin development since ODFE, on projects such as Reporting and Notification
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr