Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][Tests] Add BWC tests for 2.4.0 #2393

Merged
merged 1 commit into from
Sep 22, 2022
Merged

[CI][Tests] Add BWC tests for 2.4.0 #2393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build_and_test_workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ jobs:
working-directory: ./artifacts
strategy:
matrix:
version: [ osd-2.0.0, osd-2.1.0, osd-2.2.0 ]
version: [ osd-2.0.0, osd-2.1.0, osd-2.2.0, osd-2.3.0 ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to include 1.3.2? #2284

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is going into main (v2.4.0) for the future changes to be backward compatible with 2.3.0. I see in #2284 1.3.2 was restored into 2.x branch. Do you mean we need to restore 1.3.2 into main?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question yall. For main, it is on version 3.0.0. Via BWC tests we were actually able to realize it is not compatible to migrate directly from 1.x to 3.x which is set by OpenSearch reading which version our indices are from and rejecting the migration. So this helps us keep track and ping doc owners to ensure to note this.

tl;dr: 1.3.2 can't be added to main. Users will have to migrate from 1.x to 2.x to 3.x

steps:
- name: Checkout code
uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion bwctest.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

set -e

DEFAULT_VERSIONS="osd-2.0.0,osd-2.1.0,osd-2.2.0"
DEFAULT_VERSIONS="osd-2.0.0,osd-2.1.0,osd-2.2.0,osd-2.3.0"

function usage() {
echo ""
Expand Down
Binary file added cypress/test-data/with-security/osd-2.3.0.tar.gz
View file
Open in desktop
Binary file not shown.
Binary file added cypress/test-data/without-security/osd-2.3.0.tar.gz
View file
Open in desktop
Binary file not shown.