Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][Tests] Add BWC tests for 2.4.0 #2393

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

manasvinibs
Copy link
Member

@manasvinibs manasvinibs commented Sep 20, 2022

Signed-off-by: Manasvini B Suryanarayana manasvis@amazon.com

Description

Test data generated with:

yarn test:bwc -o https://artifacts.opensearch.org/releases/bundle/opensearch/2.3.0/opensearch-2.3.0-linux-x64.tar.gz -d https://artifacts.opensearch.org/releases/bundle/opensearch-dashboards/2.3.0/opensearch-dashboards-2.3.0-linux-x64.tar.gz -g true

yarn test:bwc -o https://artifacts.opensearch.org/releases/bundle/opensearch/2.3.0/opensearch-2.3.0-linux-x64.tar.gz -d https://artifacts.opensearch.org/releases/bundle/opensearch-dashboards/2.3.0/opensearch-dashboards-2.3.0-linux-x64.tar.gz -g true -s true

Issues Resolved

#2230

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

@manasvinibs manasvinibs requested a review from a team as a code owner September 20, 2022 18:56
@noCharger
Copy link
Contributor

Do we mean bwc tests for version 2.4.0? (since it's for backward compatibility)

@@ -186,7 +186,7 @@ jobs:
working-directory: ./artifacts
strategy:
matrix:
version: [ osd-2.0.0, osd-2.1.0, osd-2.2.0 ]
version: [ osd-2.0.0, osd-2.1.0, osd-2.2.0, osd-2.3.0 ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to include 1.3.2? #2284

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is going into main (v2.4.0) for the future changes to be backward compatible with 2.3.0. I see in #2284 1.3.2 was restored into 2.x branch. Do you mean we need to restore 1.3.2 into main?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question yall. For main, it is on version 3.0.0. Via BWC tests we were actually able to realize it is not compatible to migrate directly from 1.x to 3.x which is set by OpenSearch reading which version our indices are from and rejecting the migration. So this helps us keep track and ping doc owners to ensure to note this.

tl;dr: 1.3.2 can't be added to main. Users will have to migrate from 1.x to 2.x to 3.x

kavilla
kavilla previously approved these changes Sep 20, 2022
@manasvinibs manasvinibs changed the title [CI][Tests] Add BWC tests for 2.3.0 [CI][Tests] Add BWC tests for 2.4.0 Sep 20, 2022
@manasvinibs
Copy link
Member Author

Do we mean bwc tests for version 2.4.0? (since it's for backward compatibility)

Good catch!

Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
Copy link
Contributor

@noCharger noCharger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Mana.

@kavilla kavilla merged commit 08d0504 into opensearch-project:main Sep 22, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2393-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 08d05047d125afa7a6f5426de400b1a8b9be62c5
# Push it to GitHub
git push --set-upstream origin backport/backport-2393-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2393-to-2.x.

manasvinibs added a commit to manasvinibs/OpenSearch-Dashboards that referenced this pull request Sep 23, 2022
Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>

Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
(cherry picked from commit 08d0504)
manasvinibs added a commit to manasvinibs/OpenSearch-Dashboards that referenced this pull request Sep 23, 2022
Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>

Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
(cherry picked from commit 08d0504)
Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
manasvinibs added a commit to manasvinibs/OpenSearch-Dashboards that referenced this pull request Sep 23, 2022
…#2393)

Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
(cherry picked from commit 08d0504)
Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
manasvinibs added a commit to manasvinibs/OpenSearch-Dashboards that referenced this pull request Sep 23, 2022
…#2393)

Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
(cherry picked from commit 08d0504)
Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
manasvinibs added a commit to manasvinibs/OpenSearch-Dashboards that referenced this pull request Sep 23, 2022
…#2393)

Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
(cherry picked from commit 08d0504)
Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
kavilla pushed a commit that referenced this pull request Sep 27, 2022
Backport to this PR #2393

Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
sipopo pushed a commit to sipopo/OpenSearch-Dashboards that referenced this pull request Dec 16, 2022
Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>

Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x ci test:bwc v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants