Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"edges" field spec definition for version 0.1 #27

Merged
merged 6 commits into from
Mar 7, 2022
Merged

Conversation

Jesus89
Copy link
Collaborator

@Jesus89 Jesus89 commented Mar 4, 2022

This PR aims to cover the definition of "edges" field for version 0.1.

Closes #9

Copy link
Member

@cholmes cholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Put one small change to make it clear there are just three options, and also to change srid to crs.

At some point I think it'd be good to explain more what this is, some sort of primer on why it matters, how it interacts with the coordinate reference system. Probably doesn't need to be in the spec itself.

format-specs/geoparquet.md Outdated Show resolved Hide resolved
format-specs/geoparquet.md Outdated Show resolved Hide resolved
format-specs/geoparquet.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

format-specs/geoparquet.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@alasarr alasarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me

@Jesus89 Jesus89 merged commit 6d89657 into main Mar 7, 2022
@Jesus89 Jesus89 deleted the jarroyo/edges branch March 7, 2022 10:55
@alasarr alasarr modified the milestone: 0.1 Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store information about planar vs spherical coordinates (eg geodesic=true/false)
5 participants